Skip to content

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing #3014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Mar 19, 2025

Hi all,

This pull request contains a backport of commit 577ede73 from the openjdk/jdk repository.

The commit being backported was authored by Weijun Wang on 19 Mar 2025 and was reviewed by David Holmes.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8352302 needs maintainer approval

Issue

  • JDK-8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3014/head:pull/3014
$ git checkout pull/3014

Update a local copy of the PR:
$ git checkout pull/3014
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3014

View PR using the GUI difftool:
$ git pr show -t 3014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3014.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 19, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

@sendaoYan This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • c0e7aa6: 8303770: Remove Baltimore root certificate expiring in May 2025
  • da5bfa9: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic
  • c56a86d: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1
  • 6d469db: 8339810: Clean up the code in sun.tools.jar.Main to properly close resources and use ZipFile during extract
  • 6b7a312: 8309841: Jarsigner should print a warning if an entry is removed
  • 428c2a2: 8348596: Update FreeType to 2.13.3

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 577ede73d8e916bac9050d3bee80d2f18cc833a7 8352302: Test sun/security/tools/jarsigner/TimestampCheck.java is failing Mar 19, 2025
@openjdk
Copy link

openjdk bot commented Mar 19, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 19, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 19, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 19, 2025

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Mar 28, 2025

Please apply for approval.

@sendaoYan
Copy link
Member Author

Please apply for approval.

Sorry for the delay approval. GHA report one test failure which has been recorded by JDK-8260389, the failure is unrelated to this backport PR.

/approval request Clean backport to fix test certificate expired issue. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@sendaoYan
8352302: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Mar 31, 2025
@sendaoYan
Copy link
Member Author

Thanks for the approved.

/integrate

@openjdk
Copy link

openjdk bot commented Mar 31, 2025

Going to push as commit 690d595.
Since your change was applied there have been 6 commits pushed to the master branch:

  • c0e7aa6: 8303770: Remove Baltimore root certificate expiring in May 2025
  • da5bfa9: 8293345: SunPKCS11 provider checks on PKCS11 Mechanism are problematic
  • c56a86d: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1
  • 6d469db: 8339810: Clean up the code in sun.tools.jar.Main to properly close resources and use ZipFile during extract
  • 6b7a312: 8309841: Jarsigner should print a warning if an entry is removed
  • 428c2a2: 8348596: Update FreeType to 2.13.3

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 31, 2025
@openjdk openjdk bot closed this Mar 31, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 31, 2025
@openjdk
Copy link

openjdk bot commented Mar 31, 2025

@sendaoYan Pushed as commit 690d595.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants