Skip to content

8303770: Remove Baltimore root certificate expiring in May 2025 #3018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vieiro
Copy link
Contributor

@vieiro vieiro commented Mar 28, 2025

Clean backport of JDK-8303770.

Tested with tier1 on linux and also with:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
>> jtreg:test/jdk/sun/security                         659   658     1     0 <<
==============================
TEST FAILURE

Test failure is unrelated and is due to JDK-8352302


Progress

  • JDK-8303770 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8303770: Remove Baltimore root certificate expiring in May 2025 (Task - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3018/head:pull/3018
$ git checkout pull/3018

Update a local copy of the PR:
$ git checkout pull/3018
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3018

View PR using the GUI difftool:
$ git pr show -t 3018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3018.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 28, 2025

👋 Welcome back vieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8303770: Remove Baltimore root certificate expiring in May 2025

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 4e67796c3fcbffa706be8fabb56d00f9128edac1 8303770: Remove Baltimore root certificate expiring in May 2025 Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 28, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 28, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 28, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Mar 28, 2025

Build failures (linux s390x and ClhsdbFindPC true true with -Xcomp) are unrelated.

@vieiro
Copy link
Contributor Author

vieiro commented Mar 28, 2025

/approval request Please approve this clean backport from JDK-17 related to a root certificate expiring in May 2025.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@vieiro
8303770: Approval has already been requested and approved.

@vieiro
Copy link
Contributor Author

vieiro commented Mar 28, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@vieiro
Your change (at version 308144b) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

GHA test failures appear unrelated.

@openjdk
Copy link

openjdk bot commented Mar 28, 2025

Going to push as commit c0e7aa6.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 28, 2025
@openjdk openjdk bot closed this Mar 28, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 28, 2025
@openjdk
Copy link

openjdk bot commented Mar 28, 2025

@phohensee @vieiro Pushed as commit c0e7aa6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants