Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify #303

Closed

Conversation

@MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 31, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/303.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 31, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ea30bd6684fa3003889062a129a5aee1bc9b0024 8263362: Avoid division by 0 in java/awt/font/TextJustifier.java justify Aug 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 31, 2021

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263362: Avoid division by 0 in  java/awt/font/TextJustifier.java justify

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 135 new commits pushed to the master branch:

  • 63fc945: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC
  • 9719270: 8248666: AArch64: Use THREAD_LOCAL instead of __thread
  • c816276: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration
  • 910e24b: 8212718: Refactor some annotation processor tests to better use collections
  • 5792854: 8212695: Add explicit timeout to several HTTP Client tests
  • e5ec679: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up
  • 7100a65: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException
  • 069b4cc: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"
  • 45ed9e8: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
  • 7c872ed: 8272124: Cgroup v1 initialization causes NullPointerException when cgroup path contains colon
  • ... and 125 more: https://git.openjdk.java.net/jdk11u-dev/compare/6762216121699e1b8234cced6cd6410b5de92c09...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 31, 2021

Webrevs

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Aug 31, 2021

Hi all,

this pull request contains a backport of commit ea30bd6 from the openjdk/jdk repository.

The commit being backported was authored by Matthias Baesken on 6 May 2021 and was reviewed by Prasanta Sadhukhan.

Thanks!

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Sep 1, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

Going to push as commit d41b37f.
Since your change was applied there have been 136 commits pushed to the master branch:

  • 0ea1e0f: 8272902: Bump update version for OpenJDK: jdk-11.0.14
  • 63fc945: 8248668: AArch64: Avoid MIN/MAX macros when using MSVC
  • 9719270: 8248666: AArch64: Use THREAD_LOCAL instead of __thread
  • c816276: 8241336: Some java.net tests failed with NoRouteToHostException on MacOS with special network configuration
  • 910e24b: 8212718: Refactor some annotation processor tests to better use collections
  • 5792854: 8212695: Add explicit timeout to several HTTP Client tests
  • e5ec679: 8211325: test/jdk/java/net/Socket/LingerTest.java fails with cleaning up
  • 7100a65: 8169246: java/net/DatagramSocket/ReportSocketClosed.java fails intermittently with BindException
  • 069b4cc: 8199931: java/net/MulticastSocket/UnreferencedMulticastSockets.java fails with "incorrect data received"
  • 45ed9e8: 8263490: [macos] Crash occurs on JPasswordField with activated InputMethod
  • ... and 126 more: https://git.openjdk.java.net/jdk11u-dev/compare/6762216121699e1b8234cced6cd6410b5de92c09...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2021

@MBaesken Pushed as commit d41b37f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant