Skip to content

Conversation

@vieiro
Copy link
Contributor

@vieiro vieiro commented Sep 1, 2025

Clean backport of JDK-8355528 that updates harfbuzz levelling it with upper JDK versions and with 11.0.29-oracle.

Tested on Linux/x86_64 with tier1 tests and with jdk:jfc_demo:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jfc_demo                               1     1     0     0   
==============================
TEST SUCCESS

And also on macos 12.6.1-aarch64/XCode 13.4.1/clang 13.1.6:

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk:jfc_demo                               1     1     0     0   
==============================
TEST SUCCESS

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8355528 needs maintainer approval

Issue

  • JDK-8355528: Update HarfBuzz to 11.2.0 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3084/head:pull/3084
$ git checkout pull/3084

Update a local copy of the PR:
$ git checkout pull/3084
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3084/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3084

View PR using the GUI difftool:
$ git pr show -t 3084

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3084.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2025

👋 Welcome back avieiro! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@vieiro This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8355528: Update HarfBuzz to 11.2.0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 2a9d9094a376df4dec2b6b635bbaa20429b50615 8355528: Update HarfBuzz to 11.2.0 Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 1, 2025
@openjdk
Copy link

openjdk bot commented Sep 1, 2025

⚠️ @vieiro This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 1, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2025

Webrevs

@vieiro
Copy link
Contributor Author

vieiro commented Sep 1, 2025

/approval request Please consider approving this clean backport to 11u that updates the recently updated Harfbuzz 10.4.0 up to 11.2.0, levelling it up with upper JDK versions and with 11.0.29-oracle. Tested on Linux/x86_64 and macos/aarch64.

@openjdk
Copy link

openjdk bot commented Sep 1, 2025

@vieiro
8355528: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Sep 1, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2025

@vieiro This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@vieiro
Copy link
Contributor Author

vieiro commented Sep 29, 2025

/touch

Let's keep this one open.

@openjdk
Copy link

openjdk bot commented Sep 29, 2025

@vieiro The pull request is being re-evaluated and the inactivity timeout has been reset.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 21, 2025
@vieiro
Copy link
Contributor Author

vieiro commented Oct 21, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Oct 21, 2025

Going to push as commit c3e442a.
Since your change was applied there have been 11 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 21, 2025
@openjdk openjdk bot closed this Oct 21, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2025
@openjdk
Copy link

openjdk bot commented Oct 21, 2025

@vieiro Pushed as commit c3e442a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant