Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272966: test/jdk/java/awt/Robot/FlushCurrentEvent.java fails by timeout #309

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 2, 2021

The test case backported by the JDK-8267722 is too strict for jdk11. It uses the Robot.delay() method which is synchronised in jdk11 and this caused a deadlock.

Main thread: synchronized robot.waitForIdle() - > trying to synchronously execute the code on EDT
EDT: trying to call synchronized Robot.delay()

The synchronized keyword was removed by the JDK-8210231 in JDK15 and it cannot be backported due to compatibility reasons.

The solution is to relax this part of the test which does not affect its ability to verify the fix for JDK-8196100


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8272966: test/jdk/java/awt/Robot/FlushCurrentEvent.java fails by timeout

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/309.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 2, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@mrserb mrserb marked this pull request as ready for review Sep 2, 2021
@openjdk openjdk bot added the rfr label Sep 2, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 2, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2021

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272966: test/jdk/java/awt/Robot/FlushCurrentEvent.java fails by timeout

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 8da3a00: 8251930: AArch64: Native types mismatch in hotspot
  • cf95c4c: 8206085: Refactor langtools/tools/javac/versions/Versions.java
  • ae0d088: 8270317: Large Allocation in CipherSuite
  • c88867c: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • 1d1e4ce: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/ea1a1d86b92e43bbb4ecadf4ba3bd338b3441ad4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 9, 2021
@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 10, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

Going to push as commit 180bc52.
Since your change was applied there have been 17 commits pushed to the master branch:

  • bfb52f2: 8273547: [11u] [JVMCI] Partial module-info.java backport of JDK-8223332
  • 1e6682a: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder
  • 4ea2edd: 8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard
  • a39375e: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font
  • a013fe2: 8210395: Add doc to SecurityTools.java
  • 8da3a00: 8251930: AArch64: Native types mismatch in hotspot
  • cf95c4c: 8206085: Refactor langtools/tools/javac/versions/Versions.java
  • ae0d088: 8270317: Large Allocation in CipherSuite
  • c88867c: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • 1d1e4ce: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/ea1a1d86b92e43bbb4ecadf4ba3bd338b3441ad4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 10, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2021

@mrserb Pushed as commit 180bc52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 10, 2021
@mrserb mrserb deleted the JDK-8272966 branch Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
2 participants