New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8272966: test/jdk/java/awt/Robot/FlushCurrentEvent.java fails by timeout #309
Conversation
|
@mrserb This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 12 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
Going to push as commit 180bc52.
Your commit was automatically rebased without conflicts. |
The test case backported by the JDK-8267722 is too strict for jdk11. It uses the
Robot.delay()
method which issynchronised
in jdk11 and this caused a deadlock.Main thread:
synchronized robot.waitForIdle()
- > trying to synchronously execute the code on EDTEDT: trying to call
synchronized Robot.delay()
The synchronized keyword was removed by the JDK-8210231 in JDK15 and it cannot be backported due to compatibility reasons.
The solution is to relax this part of the test which does not affect its ability to verify the fix for JDK-8196100
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/309/head:pull/309
$ git checkout pull/309
Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/309/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 309
View PR using the GUI difftool:
$ git pr show -t 309
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/309.diff