Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269984: [macos] JTabbedPane title looks like disabled #310

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 3, 2021

Backport of JDK-8269984. Follow-up fix for ea1a1d8. Doesn't apply cleanly, because the workaround (hunk which introduced isCatalinaOrAbove) from the latter is no longer up to date and should get reverted. There are also unrelated context changes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269984: [macos] JTabbedPane title looks like disabled

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/310/head:pull/310
$ git checkout pull/310

Update a local copy of the PR:
$ git checkout pull/310
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/310/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 310

View PR using the GUI difftool:
$ git pr show -t 310

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/310.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8adf008b150bfda783ae615965198edb4d196016 8269984: [macos] JTabbedPane title looks like disabled Sep 3, 2021
@openjdk
Copy link

openjdk bot commented Sep 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 3, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2021

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(A wonder of software design this code ...)

@openjdk
Copy link

openjdk bot commented Sep 7, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269984: [macos] JTabbedPane title looks like  disabled

Reviewed-by: goetz, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2021
Copy link
Member

@mrserb mrserb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look fine, the code now identical to the mainline and work fine on macos 11.5

@TheRealMDoerr
Copy link
Contributor Author

Thanks for the reviews, testing and approval!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 7, 2021

Going to push as commit 47e4bc9.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • 9efd897: 8261236: C2: ClhsdbJstackXcompStress test fails when StressGCM is enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 7, 2021
@openjdk
Copy link

openjdk bot commented Sep 7, 2021

@TheRealMDoerr Pushed as commit 47e4bc9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8269984_macOS_JTabbedPane branch September 7, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants