New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269984: [macos] JTabbedPane title looks like disabled #310
8269984: [macos] JTabbedPane title looks like disabled #310
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(A wonder of software design this code ...)
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look fine, the code now identical to the mainline and work fine on macos 11.5
Thanks for the reviews, testing and approval! |
Going to push as commit 47e4bc9.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 47e4bc9. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8269984. Follow-up fix for ea1a1d8. Doesn't apply cleanly, because the workaround (hunk which introduced isCatalinaOrAbove) from the latter is no longer up to date and should get reverted. There are also unrelated context changes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/310/head:pull/310
$ git checkout pull/310
Update a local copy of the PR:
$ git checkout pull/310
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/310/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 310
View PR using the GUI difftool:
$ git pr show -t 310
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/310.diff