8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation#3111
8290368: Introduce LDAP and RMI protocol-specific object factory filters to JNDI implementation#3111Pooja-DP wants to merge 1 commit intoopenjdk:masterfrom
Conversation
|
👋 Welcome back Pooja-DP! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
|
Hi team, Can anyone please take a look on my PR? |
|
@RealCLanger - Could you please review my PR? |
Sorry, not working on JDK11 any more, you need to find somebody else. |
|
@phohensee - Could you please take a look on my PR? |
1 similar comment
|
@phohensee - Could you please take a look on my PR? |
gnu-andrew
left a comment
There was a problem hiding this comment.
It seems that when 8244473 was backported to 11u, documentation changes were not included so I think it is correct to include them here, along with fixing the ordering in java.security caused by patches being applied in a different order as far as I can see.
There are still some conflict hunks present in src/java.naming/share/classes/module-info.java and a couple of bits from 8244473 still missing:
--- src/java.naming/share/classes/module-info.java 2025-12-03 09:33:23.798486609 +0000
+++ ../jdk/src/java.naming/share/classes/module-info.java 2025-12-03 01:34:51.274570322 +0000
@@ -29,11 +29,11 @@
* Common standard JNDI environment properties that may be supported
* by JNDI providers are defined and documented in
* {@link javax.naming.Context}. Specific JNDI provider implementations
- * may also support other environment properties, which are specific
+ * may also support other environment or system properties, which are specific
* to their implementation.
*
* @implNote
- * The following implementation specific properties are supported by the
+ * The following implementation specific environment properties are supported by the
* default LDAP Naming Service Provider implementation in the JDK:
* <ul>
* <li>{@code java.naming.ldap.factory.socket}:
@@ -86,8 +86,6 @@
* channel binding information to the server.
* </li>
* </ul>
-<<<<<<< HEAD
-=======
* <p>The following implementation specific system properties are supported by the
* default LDAP Naming Service Provider implementation in the JDK:
* <ul>
If you can fix this up, this should be ready to go.
What testing has been done with this change?
|
Also please go to https://github.com/Pooja-DP/jdk11u-dev/actions and enable GitHub Actions as you are not running the testing on this pull request. |
|
@Pooja-DP This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
|
/keepalive |
|
@Pooja-DP The pull request is being re-evaluated and the inactivity timeout has been reset. |
Signed-off-by: Pooja.D.P <Pooja.D.P1@ibm.com>
|
@Pooja-DP Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@gnu-andrew : Thanks for reviewing my PR. I have addressed your comments and enabled git action as well https://github.com/Pooja-DP/jdk11u-dev/actions/runs/20845054449 Please take a look. Thanks |
|
@Pooja-DP This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
This pull request contains a backport of commit openjdk/jdk17u@39a6bf2 from the https://github.com/openjdk/jdk17u
Bug Ref: https://bugs.openjdk.org/browse/JDK-8290368
Signed-off-by: Pooja.D.P1 Pooja.D.P1@ibm.com
Progress
Issues
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3111/head:pull/3111$ git checkout pull/3111Update a local copy of the PR:
$ git checkout pull/3111$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3111/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3111View PR using the GUI difftool:
$ git pr show -t 3111Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3111.diff
Using Webrev
Link to Webrev Comment