8213781: web page background renders blue in JEditorPane

[TheMangovnik]

Backport of JDK-8213781 - web page background renders blue in JEditorPane

Fixing JEditorPane that for some webpages renders the background blue instead white. E.g. http://www.google.com/

Clean backport.
Passed tier1 tests. Existing failures are the same as on the unpatched code, they are unrelated.
Passed gtests.

GH Actions are passing.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8213781 needs maintainer approval
• JDK-4895924 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8213781: web page background renders blue in JEditorPane

Issues

• JDK-8213781: web page background renders blue in JEditorPane (Bug - P3 - Approved)
• JDK-4895924: Strings in format #rgb not handled by Color.decode() (affects CSS / Swing) (Bug - P4 - Approved)

Reviewers

• Andrew John Hughes (@gnu-andrew - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk11u-dev.git pull/3118/head:pull/3118
$ git checkout pull/3118

Update a local copy of the PR:
$ git checkout pull/3118
$ git pull https://git.openjdk.org/jdk11u-dev.git pull/3118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3118

View PR using the GUI difftool:
$ git pr show -t 3118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk11u-dev/pull/3118.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @TheMangovnik, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user TheMangovnik" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@TheMangovnik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213781: web page background renders blue in JEditorPane
4895924: Strings in format #rgb not handled by Color.decode() (affects CSS / Swing)

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• c5cef8c: 8257709: C1: Double assignment in InstructionPrinter::print_stack
• 3cc55c3: 8368982: Test sun/security/tools/jarsigner/EC.java completed and timed out
• 37f8029: 8341964: Add mechanism to disable different parts of TLS cipher suite
• ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/c40bce3c5f56204ca23efbc072526e2bd3581d36...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issues from the original commit.

[TheMangovnik]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[openjdk]

⚠️ @TheMangovnik This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (80da9973)

[TheMangovnik]

/approval request Clean back port fixing background rendering for some webpages when JEditorPane is used. Tests run on fedora 43. Gtests passed, same T1 failing before and after the backport - not related to this issue.

[openjdk]

@TheMangovnik
8213781: The approval request has been created successfully.
4895924: The approval request has been created successfully.

[gnu-andrew]

Confirmed clean. Does the new test pass?

[gnu-andrew]

Do you intend to follow this with JDK-8367348? It feels like this is a pre-requisite for that change.

[TheMangovnik]

Confirmed clean. Does the new test pass?

Yes, it does.
EDIT: The tests passes on X11, fails on Wayland.

$ make run-test-only TEST="jtreg:test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java"
Building target 'run-test-only' in configuration 'linux-x86_64-normal-server-release'
Test selection 'jtreg:test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java', will run:
* jtreg:test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java

Running test 'jtreg:test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java'
Passed: javax/swing/JEditorPane/TestBrowserBGColor.java
Test results: passed: 1
Report written to /home/dsladky/dev/jdk11u-dev/build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_javax_swing_JEditorPane_TestBrowserBGColor_java/html/report.html
Results written to /home/dsladky/dev/jdk11u-dev/build/linux-x86_64-normal-server-release/test-support/jtreg_test_jdk_javax_swing_JEditorPane_TestBrowserBGColor_java
Finished running test 'jtreg:test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java'
Test report is stored in build/linux-x86_64-normal-server-release/test-results/jtreg_test_jdk_javax_swing_JEditorPane_TestBrowserBGColor_java

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR
   jtreg:test/jdk/javax/swing/JEditorPane/TestBrowserBGColor.java
                                                         1     1     0     0
==============================
TEST SUCCESS

Finished building target 'run-test-only' in configuration 'linux-x86_64-normal-server-release'

Do you intend to follow this with JDK-8367348? It feels like this is a pre-requisite for that change.

Yes, that is the issue that led me to this one and I am planning to continue with the chain of backports.

[gnu-andrew]

Thanks, I think this one is good to go.

[gnu-andrew]

/approve yes

[openjdk]

@gnu-andrew
8213781: The approval request has been approved.
4895924: The approval request has been approved.

[TheMangovnik]

/integrate

[openjdk]

@TheMangovnik
Your change (at version 80da997) is now ready to be sponsored by a Committer.

[gnu-andrew]

/sponsor

[openjdk]

Going to push as commit 1939efc.
Since your change was applied there have been 13 commits pushed to the master branch:

• c5cef8c: 8257709: C1: Double assignment in InstructionPrinter::print_stack
• 3cc55c3: 8368982: Test sun/security/tools/jarsigner/EC.java completed and timed out
• 37f8029: 8341964: Add mechanism to disable different parts of TLS cipher suite
• ... and 10 more: https://git.openjdk.org/jdk11u-dev/compare/c40bce3c5f56204ca23efbc072526e2bd3581d36...master

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew @TheMangovnik Pushed as commit 1939efc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.