Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270317: Large Allocation in CipherSuite #312

Conversation

cliveverghese
Copy link
Contributor

@cliveverghese cliveverghese commented Sep 3, 2021

Hi all,

This pull request contains a backport of commit e627caec from the openjdk/jdk repository.

The commit being backported was authored by Clive Verghese on 24 Jul 2021 and was reviewed by Xue-Lei Andrew Fan and Volker Simonis.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/312/head:pull/312
$ git checkout pull/312

Update a local copy of the PR:
$ git checkout pull/312
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 312

View PR using the GUI difftool:
$ git pr show -t 312

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/312.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2021

👋 Welcome back cverghese! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e627caec84c169c99c04e0d355c29b806a0266ed 8270317: Large Allocation in CipherSuite Sep 3, 2021
@openjdk
Copy link

openjdk bot commented Sep 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 3, 2021

@cliveverghese This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270317: Large Allocation in CipherSuite

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • c88867c: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • 1d1e4ce: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2021

Webrevs

@cliveverghese
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@cliveverghese
Your change (at version f7d3616) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

Going to push as commit ae0d088.
Since your change was applied there have been 7 commits pushed to the master branch:

  • c88867c: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked
  • 1d1e4ce: 8251570: JDK-8215624 causes assert(worker_id < _n_workers) failed: Invalid worker_id
  • 085dbe3: 8215624: Add parallel heap iteration for jmap –histo
  • 2de01c1: 8269993: [Test]: java/net/httpclient/DigestEchoClientSSL.java contains redundant @run tags
  • 47e4bc9: 8269984: [macos] JTabbedPane title looks like disabled
  • 569688f: 8272316: Wrong Boot JDK help message in 11
  • 1645dbe: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@phohensee @cliveverghese Pushed as commit ae0d088.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants