Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8272316: Wrong Boot JDK help message in 11 #313

Closed
wants to merge 2 commits into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 6, 2021

Hello please review this small fix. It fixes the configure help output message and mentions openjdk-11-jdk because 8 is not sufficient to build jdk11 as BOOT JDK.

Thanks, Matthias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/313/head:pull/313
$ git checkout pull/313

Update a local copy of the PR:
$ git checkout pull/313
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/313/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 313

View PR using the GUI difftool:
$ git pr show -t 313

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/313.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 6, 2021

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 6, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 6, 2021

Webrevs

tstuefe
tstuefe approved these changes Sep 6, 2021
Copy link
Member

@tstuefe tstuefe left a comment

Looks good & trivial.

Want to fix it for yum too? I believe that would be "yum install java-11-openjdk-devel", but I have no Red Hat distro to check.

Cheers, Thomas

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@MBaesken This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272316: Wrong Boot JDK help message in 11

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 6, 2021
@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Sep 6, 2021

Looks good & trivial.

Want to fix it for yum too? I believe that would be "yum install java-11-openjdk-devel", but I have no Red Hat distro to check.

Cheers, Thomas

Hi Thomas, yes the yum output should be changed too. I adjusted this in my additional commit.

Thanks, Matthias

@tstuefe
Copy link
Member

@tstuefe tstuefe commented Sep 6, 2021

Looks still good.

@MBaesken
Copy link
Member Author

@MBaesken MBaesken commented Sep 6, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

Going to push as commit 569688f.

@openjdk openjdk bot closed this Sep 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 6, 2021

@MBaesken Pushed as commit 569688f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 6, 2021

@MBaesken please take care to follow the standard jdk11u-fix-request procedure, also for JDK11 only changes.

Furthermore I'm not sure wheter backporting JDK-8219788 would have been the better choice here.

@MBaesken MBaesken deleted the JDK-8272316 branch Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants