Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8195703: BasicJDWPConnectionTest.java: 'App exited unexpectedly with 2' #316

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 8, 2021

Backport of JDK-8195703. Needed trivial resolve in BasicJDWPConnectionTest.java, diff looks identical though.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8195703: BasicJDWPConnectionTest.java: 'App exited unexpectedly with 2'

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/316/head:pull/316
$ git checkout pull/316

Update a local copy of the PR:
$ git checkout pull/316
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/316/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 316

View PR using the GUI difftool:
$ git pr show -t 316

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/316.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 8, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 24fb839864c441594b1fa0f2a20366581d45a7ac 8195703: BasicJDWPConnectionTest.java: 'App exited unexpectedly with 2' Sep 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 8, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 8, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8195703: BasicJDWPConnectionTest.java: 'App exited unexpectedly with 2'

Reviewed-by: phh, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 8, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 11, 2021

Thanks for the reviews.
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2021

Going to push as commit 5a5d246.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 180bc52: 8272966: test/jdk/java/awt/Robot/FlushCurrentEvent.java fails by timeout
  • bfb52f2: 8273547: [11u] [JVMCI] Partial module-info.java backport of JDK-8223332
  • 1e6682a: 8247403: JShell: No custom input (e.g. from GUI) possible with JavaShellToolBuilder
  • 4ea2edd: 8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard
  • a39375e: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font
  • a013fe2: 8210395: Add doc to SecurityTools.java
  • 8da3a00: 8251930: AArch64: Native types mismatch in hotspot
  • cf95c4c: 8206085: Refactor langtools/tools/javac/versions/Versions.java
  • ae0d088: 8270317: Large Allocation in CipherSuite

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 11, 2021

@RealCLanger Pushed as commit 5a5d246.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-24fb8398 branch Sep 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants