-
Notifications
You must be signed in to change notification settings - Fork 251
8273547: [11u] [JVMCI] Partial module-info.java backport of JDK-8223332 #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273547: [11u] [JVMCI] Partial module-info.java backport of JDK-8223332 #318
Conversation
|
👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into |
Webrevs
|
|
@jerboaa This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
RealCLanger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 😃
|
/integrate |
|
Going to push as commit bfb52f2.
Your commit was automatically rebased without conflicts. |
Please review this trivial partial backport of JDK-8223332. The full patch is too large and isn't worth the risk to backport in full. The issue at hand can be resolved by adding only the exports to the
jdk.internal.vm.cimodule. Thoughts?Testing: jvmci tests, jvmci bootstrap tests, manual testing of the reproducer and tier1 on Linux x86_64
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/318/head:pull/318$ git checkout pull/318Update a local copy of the PR:
$ git checkout pull/318$ git pull https://git.openjdk.java.net/jdk11u-dev pull/318/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 318View PR using the GUI difftool:
$ git pr show -t 318Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/318.diff