Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API #32

Conversation

AlexanderScherbatiy
Copy link

@AlexanderScherbatiy AlexanderScherbatiy commented Jun 15, 2021

This is a direct backport of the fix JDK-8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API to jdk11u-dev.
The patch applies cleanly.

The fix has been built with the latest jdk11u-dev sources on Ubuntu 18.04 and manually tested with reactor-core-3.4.5.jar lib.

The jdeps output without the fix is jdk8internals:

build/linux-x86_64-normal-server-release/jdk/bin/jdeps -s reactor-core-3.4.5.jar 
reactor-core-3.4.5.jar -> jdk8internals
reactor-core-3.4.5.jar -> java.base
reactor-core-3.4.5.jar -> java.logging
reactor-core-3.4.5.jar -> not found

and with the fix is JDK removed internal API

build/linux-x86_64-normal-server-release/jdk/bin/jdeps -s reactor-core-3.4.5.jar 
reactor-core-3.4.5.jar -> JDK removed internal API
reactor-core-3.4.5.jar -> java.base
reactor-core-3.4.5.jar -> java.logging
reactor-core-3.4.5.jar -> not found

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/32/head:pull/32
$ git checkout pull/32

Update a local copy of the PR:
$ git checkout pull/32
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/32/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 32

View PR using the GUI difftool:
$ git pr show -t 32

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/32.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 15, 2021

👋 Welcome back alexsch! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 15, 2021
@mlbridge
Copy link

mlbridge bot commented Jun 15, 2021

Webrevs

@AlexanderScherbatiy AlexanderScherbatiy changed the title 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API Backport b3b2bb2875fc30d550d80e09c3e2b3f257a29869 Jun 15, 2021
@openjdk openjdk bot changed the title Backport b3b2bb2875fc30d550d80e09c3e2b3f257a29869 8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API Jun 15, 2021
@openjdk
Copy link

openjdk bot commented Jun 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 15, 2021

@AlexanderScherbatiy This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265773: incorrect jdeps message "jdk8internals" to describe a removed JDK internal API

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • 0605504: 8181313: SA: Remove libthread_db dependency on Linux
  • 23719ae: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 9638c41: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • 57d8e1e: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 4e19090: 8268103: JNI functions incorrectly return a double after JDK-8265836

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 15, 2021
@jerboaa
Copy link
Contributor

jerboaa commented Jun 21, 2021

This is a clean backport. It only needs maintainer approval in the bug. Please add "Fix Request" comment and appropriate label.

@AlexanderScherbatiy
Copy link
Author

This is a clean backport. It only needs maintainer approval in the bug. Please add "Fix Request" comment and appropriate label.

What does jdk11u-fix-yes label mean for the backport?
Does it mean that the clean backport will be automatically backported to jdk11u-dev repository or it needs to be backported manually?

According to JDK11u Wiki page:

The maintainers will either approve by setting jdk11u-fix-yes or reject 
by setting jdk11u-fix-no...
If and only if the fix gets approved, it may be pushed
to the jdk11u-dev repository.

Is it still correct information and the backport needs to be manually pushed to jdk11u-dev mercurial repository?

@jerboaa
Copy link
Contributor

jerboaa commented Jun 24, 2021

This is a clean backport. It only needs maintainer approval in the bug. Please add "Fix Request" comment and appropriate label.

What does jdk11u-fix-yes label mean for the backport?
Does it mean that the clean backport will be automatically backported to jdk11u-dev repository or it needs to be backported manually?

According to JDK11u Wiki page:

The maintainers will either approve by setting jdk11u-fix-yes or reject 
by setting jdk11u-fix-no...
If and only if the fix gets approved, it may be pushed
to the jdk11u-dev repository.

The wiki is correct. The confusion seems to be about pushing changes. Since jdk11u-dev is in Git now you have to push there. The way to do this is by using the /integrate pull request command if and only iff your bug was granted jdk11u-fix-yes.

Is it still correct information and the backport needs to be manually pushed to jdk11u-dev mercurial repository?

No. Mercurial is read-only now.

@AlexanderScherbatiy
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 24, 2021

Going to push as commit dcd1044.
Since your change was applied there have been 15 commits pushed to the master branch:

  • ed48e5c: 8226533: JVMCI: findUniqueConcreteMethod should handle statically bindable methods directly
  • 8d5b37a: 8223050: JVMCI: findUniqueConcreteMethod() should not use Dependencies::find_unique_concrete_method() for non-virtual methods
  • 3f67b07: 8267751: (test) jtreg.SkippedException has no serial VersionUID
  • 46fd6d2: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • 881100f: 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java
  • 3c54e03: 8251945: SIGSEGV in PackageEntry::purge_qualified_exports()
  • cbe9c1b: 8213137: Remove static initialization of monitor/mutex instances
  • e44258c: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 9420012: 8024368: private methods are allocated vtable indices
  • cfdfee7: 8241353: NPE in ToolProvider.getSystemJavaCompiler
  • ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/37f36d5c46a7b6067143cfe924f62e477e6432d3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 24, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 24, 2021
@openjdk
Copy link

openjdk bot commented Jun 24, 2021

@AlexanderScherbatiy Pushed as commit dcd1044.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlexanderScherbatiy AlexanderScherbatiy deleted the backport-b3b2bb2875fc30d550d80e09c3e2b3f257a29869 branch June 24, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants