Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard #320

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 9, 2021

Clean backport of JDK-8260690.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/320/head:pull/320
$ git checkout pull/320

Update a local copy of the PR:
$ git checkout pull/320
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/320/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 320

View PR using the GUI difftool:
$ git pr show -t 320

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/320.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 9, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5d32bbfc716870904e91ce07a09f08929f2563e 8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8260690: JConsole User Guide Link from the Help menu is not accessible by keyboard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 9, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 9, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 10, 2021

Going to push as commit 4ea2edd.
Since your change was applied there have been 5 commits pushed to the master branch:

  • a39375e: 8256372: [macos] Unexpected symbol was displayed on JTextField with Monospaced font
  • a013fe2: 8210395: Add doc to SecurityTools.java
  • 8da3a00: 8251930: AArch64: Native types mismatch in hotspot
  • cf95c4c: 8206085: Refactor langtools/tools/javac/versions/Versions.java
  • ae0d088: 8270317: Large Allocation in CipherSuite

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 10, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 10, 2021
@openjdk
Copy link

openjdk bot commented Sep 10, 2021

@TheRealMDoerr Pushed as commit 4ea2edd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant