8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

[jovanstevanovic]

This PR is backporting changes from PR on the OpenJDK repo.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/324/head:pull/324
$ git checkout pull/324

Update a local copy of the PR:
$ git checkout pull/324
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/324/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 324

View PR using the GUI difftool:
$ git pr show -t 324

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/324.diff

[bridgekeeper]

👋 Welcome back jovanstevanovic! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full (fc839184)
• 00: Full (b54d4adc)

[RealCLanger]

Hi, @jovanstevanovic, Thanks for doing this backport.
First of all, can you also bring this to JDK17u as this is an LTS as well and we should not miss this in there. Furthermore, could you enable GithubActions testing on your fork? And, one more thing - what did you have to modify for this backport? Thanks 😄

[jovanstevanovic]

Hi, @jovanstevanovic, Thanks for doing this backport.
First of all, can you also bring this to JDK17u as this is an LTS as well and we should not miss this in there. Furthermore, could you enable GithubActions testing on your fork? And, one more thing - what did you have to modify for this backport? Thanks, smile

Hi, @RealCLanger, Thank you for your time!

• PR on JDK17 is here.
• GHAction is enabled.
• Last but not least. Without these changes, XSLT is not working on GraalVM's Native Image. So we need to backport these changes into JDK11, and then, before a new release of Native Image, we will backport these changes into labsjdk11, which is our own specific version of JDK11.

[RealCLanger]

Hi, @jovanstevanovic, Thanks for doing this backport.
First of all, can you also bring this to JDK17u as this is an LTS as well and we should not miss this in there. Furthermore, could you enable GithubActions testing on your fork? And, one more thing - what did you have to modify for this backport? Thanks, smile

Hi, @RealCLanger, Thank you for your time!

• PR on JDK17 is here.
• GHAction is enabled.
• Last but not least. Without these changes, XSLT is not working on GraalVM's Native Image. So we need to backport these changes into JDK11, and then, before a new release of Native Image, we will backport these changes into labsjdk11, which is our own specific version of JDK11.

OK, great. Now this PR is not properly recognized as backport of JDK-8273278. To fix this, please rename this PR (modify its title) into "Backport f690a01f1e5de4ace39aefad656cb7c99f9ec4e1". That's the hash of the original commit. The bots will recognize this and then correctly process the PR. Please do the same for the 17u Backport.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[jovanstevanovic]

Hi, @jovanstevanovic, Thanks for doing this backport.
First of all, can you also bring this to JDK17u as this is an LTS as well and we should not miss this in there. Furthermore, could you enable GithubActions testing on your fork? And, one more thing - what did you have to modify for this backport? Thanks, smile

Hi, @RealCLanger, Thank you for your time!

• PR on JDK17 is here.
• GHAction is enabled.
• Last but not least. Without these changes, XSLT is not working on GraalVM's Native Image. So we need to backport these changes into JDK11, and then, before a new release of Native Image, we will backport these changes into labsjdk11, which is our own specific version of JDK11.

OK, great. Now this PR is not properly recognized as backport of JDK-8273278. To fix this, please rename this PR (modify its title) into "Backport f690a01f1e5de4ace39aefad656cb7c99f9ec4e1". That's the hash of the original commit. The bots will recognize this and then correctly process the PR. Please do the same for the 17u Backport.

My bad. Done.

[RealCLanger]

Seems like some manual resolving of the changes to MethodGenerator.java was needed, but this looks correct.

[RealCLanger]

Now you still need to do the jdk11u-fix-request dance in JBS to obtain push approval. 😄

[openjdk]

⚠️ @jovanstevanovic the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout jovanstevanovic/improving-xslt-support-for-native-image
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@jovanstevanovic This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273278: Support XSLT on GraalVM Native Image--deterministic bytecode generation in XSLT

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 1868c15: 8237354: Add option to jcmd to write a gzipped heap dump

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[RealCLanger]

/integrate

It's not yet allowed to merge this. For OpenJDK update releases it's not sufficient to have a fromal review in the PR but the release maintainers need to approve a change whether it is appropriate to go into an update release. You can read more about the process here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u

So, as I've written above, you need to add a jdk11u-fix-request label to the bug and a comment about reason, risk and testing. Same goes for jdk17u.

[openjdk]

@jovanstevanovic
Your change (at version fc83918) is now ready to be sponsored by a Committer.

[jovanstevanovic]

/integrate

It's not yet allowed to merge this. For OpenJDK update releases it's not sufficient to have a fromal review in the PR but the release maintainers need to approve a change whether it is appropriate to go into an update release. You can read more about the process here: https://wiki.openjdk.java.net/display/JDKUpdates/JDK11u

So, as I've written above, you need to add a jdk11u-fix-request label to the bug and a comment about reason, risk and testing. Same goes for jdk17u.

Sorry, I didn't see the above comment. I'll add the labels and explanation 😄

[RealCLanger]

@jovanstevanovic As this backport was rejected (for details see JBS issue comments), I would like to ask you to close this PR. Thanks!

[jovanstevanovic]

@jovanstevanovic As this backport was rejected (for details see JBS issue comments), I would like to ask you to close this PR. Thanks!

Yes, I see, sure! Thank you for your guidance! 😄