Skip to content

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 10, 2021

Backport of JDK-8218483. Hotspot changes apply clean. Changes to gtest threadHelper.inline.hpp needed to be performed in utilitiesHelper.inline.hpp.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/326/head:pull/326
$ git checkout pull/326

Update a local copy of the PR:
$ git checkout pull/326
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/326/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 326

View PR using the GUI difftool:
$ git pr show -t 326

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/326.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 10, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2f20909d10ae33d93d62f5dcd4915efdbd83d968 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5" Sep 10, 2021
@openjdk
Copy link

openjdk bot commented Sep 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 10, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 10, 2021

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@openjdk
Copy link

openjdk bot commented Sep 11, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 126f1a2: 8225083: Remove Google certificate that is expiring in December 2021
  • 90ecf27: 8213263: fix legal headers in test/langtools
  • dee030c: 8210353: Move java/util/Arrays/TimSortStackSize2.java back to tier1
  • 5a5d246: 8195703: BasicJDWPConnectionTest.java: 'App exited unexpectedly with 2'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 11, 2021
@RealCLanger
Copy link
Contributor Author

Thanks for the review & approval.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2021

Going to push as commit d79b68e.
Since your change was applied there have been 22 commits pushed to the master branch:

  • 2212683: 8213330: Fix legal headers in i18n tests
  • 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • 9437d45: 8252049: Native memory leak in ciMethodData ctor
  • 3319efb: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • 87299f3: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 625690e: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 977ca31: 8273671: Backport of 8260616 misses one JNF header inclusion removal
  • 59f0ea3: 8213301: Fix legal headers in jdk logging tests
  • ... and 12 more: https://git.openjdk.java.net/jdk11u-dev/compare/180bc526b025e815b43070150369ae399e27753f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@RealCLanger Pushed as commit d79b68e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-2f20909d branch September 16, 2021 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants