New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8213306: Fix legal headers in test/java/nio #329
8213306: Fix legal headers in test/java/nio #329
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Update: wait, now I start having doubts. Should we even backport copyright changes?
Yes, that does no harm, there is no risk. I prefer to have parity to Oracle, where possible. (And thanks for the review |
/integrate |
Going to push as commit 1d09112.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 1d09112. |
Hi all,
this pull request contains a backport of JDK-8213306 from the openjdk/jdk repository.
The commit being backported was authored by Brian Burkhalter on 2 Nov 2018 and was reviewed by Chris Hegarty.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/329/head:pull/329
$ git checkout pull/329
Update a local copy of the PR:
$ git checkout pull/329
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/329/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 329
View PR using the GUI difftool:
$ git pr show -t 329
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/329.diff