8268771: javadoc -notimestamp option does not work on index.html

[varpa89]

In jdk 14 there was a change which allows conditionally generate timestamp in index.html of javadoc.
It would be nice to have this feature in jdk 11 for supporting reproducible builds

openjdk/jdk14u@2ace3e6#diff-ac839a98e6e91aa8aba6e1b9efdfc018616306f478fc95bae067dfc44d3667d4

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8268771: javadoc -notimestamp option does not work on index.html

Reviewers

• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/33/head:pull/33
$ git checkout pull/33

Update a local copy of the PR:
$ git checkout pull/33
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/33/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 33

View PR using the GUI difftool:
$ git pr show -t 33

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/33.diff

[bridgekeeper]

Hi @varpa89, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user varpa89" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[varpa89]

/signed

[bridgekeeper]

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[michael-o]

Maven PMC here, we are getting annoying reports about this. Please address.

[mlbridge]

Webrevs

• 01: Full - Incremental (4fb26437)
• 00: Full (942a539b)

[RealCLanger]

Looks good to me and makes sense to backport to 11u. I've requested approval in the JBS item.

[openjdk]

⚠️ @varpa89 the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout jdk-8268771
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@varpa89 This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268771: javadoc -notimestamp option does not work on index.html

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

• f56d1f6: 8266480: Implicit null check optimization does not update control of hoisted memory operation
• 2c2cc74: 8261496: Shenandoah: reconsider pacing updates memory ordering
• a092a17: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
• 80a72de: 8266018: Shenandoah: fix an incorrect assert
• a0958a8: 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'.
• 66d4ee9: 8247421: [TESTBUG] ReturnBlobToWrongHeapTest.java failed allocating blob
• df587c7: 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M
• c39f3f7: 8193214: Incorrect annotations.without.processors warnings with JDK 9
• 34d1c92: 8231717: Improve performance of charset decoding when charset is always compactable
• 48c1f60: 8263227: C2: inconsistent spilling due to dead nodes in exception block
• ... and 17 more: https://git.openjdk.java.net/jdk11u-dev/compare/9dc882645a6eb79e068fcaf018c763d9036d7da2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[varpa89]

/integrate

[openjdk]

@varpa89
Your change (at version 4fb2643) is now ready to be sponsored by a Committer.

[RealCLanger]

@varpa89
Your change (at version 4fb2643) is now ready to be sponsored by a Committer.

Need to wait with sponsoring until JBS bug gets approved for 11u.

[michael-o]

Thank you folks!

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit d522372.
Since your change was applied there have been 31 commits pushed to the master branch:

• e62d6a2: 8140466: ChaCha20 and Poly1305 TLS Cipher Suites
• 8a40d25: 8268617: [11u REDO] - WebSocket over authenticating proxy fails with NPE
• b74d798: 8265335: Epsilon: Minor typo in EpsilonElasticTLABDecay description
• 5a7e7d3: 8265761: Font with missed font family name is not properly printed on Windows
• f56d1f6: 8266480: Implicit null check optimization does not update control of hoisted memory operation
• 2c2cc74: 8261496: Shenandoah: reconsider pacing updates memory ordering
• a092a17: 8266813: Shenandoah: Use shorter instruction sequence for checking if marking in progress
• 80a72de: 8266018: Shenandoah: fix an incorrect assert
• a0958a8: 8210959: JShell fails and exits when statement throws an exception whose message contains a '%'.
• 66d4ee9: 8247421: [TESTBUG] ReturnBlobToWrongHeapTest.java failed allocating blob
• ... and 21 more: https://git.openjdk.java.net/jdk11u-dev/compare/9dc882645a6eb79e068fcaf018c763d9036d7da2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @varpa89 Pushed as commit d522372.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.