Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213301: Fix legal headers in jdk logging tests #331

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 12, 2021

Hi all,

this pull request contains a backport of JDK-8213301 from the openjdk/jdk repository.

The commit being backported was authored by Daniel Fuchs on 5 Nov 2018 and was reviewed by Chris Hegarty and Mandy Chung.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/331/head:pull/331
$ git checkout pull/331

Update a local copy of the PR:
$ git checkout pull/331
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/331/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 331

View PR using the GUI difftool:
$ git pr show -t 331

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/331.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 059682d68136d3d82cede2db774989fabefafa24 8213301: Fix legal headers in jdk logging tests Sep 12, 2021
@openjdk
Copy link

openjdk bot commented Sep 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 12, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213301: Fix legal headers in jdk logging tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 12, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

RealCLanger commented Sep 14, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

Going to push as commit 59f0ea3.
Since your change was applied there have been 8 commits pushed to the master branch:

  • dc43ace: 8213328: Update test copyrights in test/java/util/zip and test/jdk/tools
  • 1d09112: 8213306: Fix legal headers in test/java/nio
  • 97d37b8: 8213305: Fix legal headers in test/java/math
  • 77bbf1e: 8213296: Fix legal headers in test/jdk/java/net
  • 124f3ac: 8211227: Inconsistent TLS protocol version in debug output
  • 74eed68: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"
  • 4af62d8: 8250863: Build error with GCC 10 in NetworkInterface.c and k_standard.c
  • 1868c15: 8237354: Add option to jcmd to write a gzipped heap dump

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 14, 2021
@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@RealCLanger Pushed as commit 59f0ea3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant