New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8211227: Inconsistent TLS protocol version in debug output #332
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the
|
Thanks for the review and the approval! |
Going to push as commit 124f3ac.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 124f3ac. |
Almost clean backport of JDK-8211227. Test LoggingFormatConsistency needs workaround for missing JDK-8230435 in 11u:
serverAddress
is not defined.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/332/head:pull/332
$ git checkout pull/332
Update a local copy of the PR:
$ git checkout pull/332
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/332/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 332
View PR using the GUI difftool:
$ git pr show -t 332
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/332.diff