New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling #333
Conversation
👋 Welcome back lucy! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@RealLucy This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 14 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thank you, Martin, for the review. |
Finally, tests on linuxppcle and linuxs390 ran. No issues detected. Ready to integrate. |
/integrate |
/sponsor |
Going to push as commit 579fbcb.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr @RealLucy Pushed as commit 579fbcb. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thank you for sponsoring, Martin! |
Please review this backport PR.
The original change did not apply cleanly for three minor reasons (frame_ppc.cpp and frame_s390.cpp):
Crashes attributable to code fixed with this patch are observed in jdk11 jfr tests.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/333/head:pull/333
$ git checkout pull/333
Update a local copy of the PR:
$ git checkout pull/333
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/333/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 333
View PR using the GUI difftool:
$ git pr show -t 333
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/333.diff