Skip to content

8213330: Fix legal headers in i18n tests #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 13, 2021

Backport of JDK-8213330. Change applies cleanly on files that exist in 11. Some don't so obviously those can't be changed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/340/head:pull/340
$ git checkout pull/340

Update a local copy of the PR:
$ git checkout pull/340
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/340/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 340

View PR using the GUI difftool:
$ git pr show -t 340

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/340.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 13, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a1029a472983b457707f8807b160b7eaf4a123f9 8213330: Fix legal headers in i18n tests Sep 13, 2021
@openjdk
Copy link

openjdk bot commented Sep 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 13, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 13, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213330: Fix legal headers in i18n tests

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 124f3ac: 8211227: Inconsistent TLS protocol version in debug output
  • 74eed68: 8228442: DHKeyExchange/LegacyDHEKeyExchange.java failed due to "SSLException: An established connection was aborted by the software in your host machine"
  • 4af62d8: 8250863: Build error with GCC 10 in NetworkInterface.c and k_standard.c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2021
@RealCLanger
Copy link
Contributor Author

/integrate

@RealCLanger
Copy link
Contributor Author

Thanks for the review.

@openjdk
Copy link

openjdk bot commented Sep 16, 2021

Going to push as commit 2212683.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • 9437d45: 8252049: Native memory leak in ciMethodData ctor
  • 3319efb: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • 87299f3: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 625690e: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 977ca31: 8273671: Backport of 8260616 misses one JNF header inclusion removal
  • 59f0ea3: 8213301: Fix legal headers in jdk logging tests
  • dc43ace: 8213328: Update test copyrights in test/java/util/zip and test/jdk/tools
  • ... and 6 more: https://git.openjdk.java.net/jdk11u-dev/compare/1868c15d4e5d03895a4a07edacd864021dfbac57...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@RealCLanger Pushed as commit 2212683.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-a1029a47 branch September 16, 2021 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants