Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268019: C2: assert(no_dead_loop) failed: dead loop detected #342

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 14, 2021

Backport of JDK-8268019. Applies cleanly, but test needs modification. Some VM options from the original test are not available in 11u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8268019: C2: assert(no_dead_loop) failed: dead loop detected

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/342/head:pull/342
$ git checkout pull/342

Update a local copy of the PR:
$ git checkout pull/342
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 342

View PR using the GUI difftool:
$ git pr show -t 342

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/342.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 489e5fd12a37a45f4f5ea64b05f85c6f99f70811 8268019: C2: assert(no_dead_loop) failed: dead loop detected Sep 14, 2021
@openjdk
Copy link

openjdk bot commented Sep 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 14, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8268019: C2: assert(no_dead_loop) failed: dead loop detected

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 124f3ac: 8211227: Inconsistent TLS protocol version in debug output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 14, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 15, 2021

Going to push as commit 87299f3.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 625690e: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 977ca31: 8273671: Backport of 8260616 misses one JNF header inclusion removal
  • 59f0ea3: 8213301: Fix legal headers in jdk logging tests
  • dc43ace: 8213328: Update test copyrights in test/java/util/zip and test/jdk/tools
  • 1d09112: 8213306: Fix legal headers in test/java/nio
  • 97d37b8: 8213305: Fix legal headers in test/java/math
  • 77bbf1e: 8213296: Fix legal headers in test/jdk/java/net
  • 124f3ac: 8211227: Inconsistent TLS protocol version in debug output

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 15, 2021
@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 15, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8268019_C2 branch September 15, 2021 08:23
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@TheRealMDoerr Pushed as commit 87299f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants