-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8273358: macOS Monterey does not have the font Times needed by Serif #343
Conversation
👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@TheRealMDoerr This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 (though the doubtful Thomas in me wonders whether the warning just disappeared due to the changed warning condition)
Thanks for the review! Tests have passed after my trivial fix. |
Going to push as commit 376d422.
Your commit was automatically rebased without conflicts. |
@TheRealMDoerr Pushed as commit 376d422. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport of JDK-8273358. FontUtilities.logSevere/Warning need to be replaced because they are not available in 11u.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/343/head:pull/343
$ git checkout pull/343
Update a local copy of the PR:
$ git checkout pull/343
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/343/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 343
View PR using the GUI difftool:
$ git pr show -t 343
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/343.diff