Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273358: macOS Monterey does not have the font Times needed by Serif #343

Closed
wants to merge 2 commits into from
Closed

8273358: macOS Monterey does not have the font Times needed by Serif #343

wants to merge 2 commits into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 14, 2021

Clean backport of JDK-8273358. FontUtilities.logSevere/Warning need to be replaced because they are not available in 11u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273358: macOS Monterey does not have the font Times needed by Serif

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/343/head:pull/343
$ git checkout pull/343

Update a local copy of the PR:
$ git checkout pull/343
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/343/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 343

View PR using the GUI difftool:
$ git pr show -t 343

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/343.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport efe3ed1e705a6f3785761e64f7187de809daa731 8273358: macOS Monterey does not have the font Times needed by Serif Sep 14, 2021
@openjdk
Copy link

openjdk bot commented Sep 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 14, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273358: macOS Monterey does not have the font Times needed by Serif

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 124f3ac: 8211227: Inconsistent TLS protocol version in debug output

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 14, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2021

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (though the doubtful Thomas in me wonders whether the warning just disappeared due to the changed warning condition)

@openjdk openjdk bot removed the clean label Sep 14, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review! Tests have passed after my trivial fix.
/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2021

Going to push as commit 376d422.
Since your change was applied there have been 16 commits pushed to the master branch:

  • d79b68e: 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"
  • 2212683: 8213330: Fix legal headers in i18n tests
  • 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • 9437d45: 8252049: Native memory leak in ciMethodData ctor
  • 3319efb: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • 87299f3: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 625690e: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 977ca31: 8273671: Backport of 8260616 misses one JNF header inclusion removal
  • ... and 6 more: https://git.openjdk.java.net/jdk11u-dev/compare/74eed68892cf5c0fcde5d88eb0e1070e239b7af3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8273358_MacOS_12 branch September 16, 2021 12:37
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@TheRealMDoerr Pushed as commit 376d422.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants