Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272806: [macOS] "Apple AWT Internal Exception" when input method is changed #345

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 14, 2021

Clean backport of JDK-8272806.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/345/head:pull/345
$ git checkout pull/345

Update a local copy of the PR:
$ git checkout pull/345
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/345/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 345

View PR using the GUI difftool:
$ git pr show -t 345

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/345.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f681d6544ac2506cb72e45c1f9ed8dfbbde099f2 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272806: [macOS] "Apple AWT Internal Exception" when input method is changed

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 14, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

+1

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Sep 16, 2021

Thanks for the review!
/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit 25cad2f.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 0da130e: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 376d422: 8273358: macOS Monterey does not have the font Times needed by Serif
  • d79b68e: 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"
  • 2212683: 8213330: Fix legal headers in i18n tests
  • 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • 9437d45: 8252049: Native memory leak in ciMethodData ctor
  • 3319efb: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • 87299f3: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • ... and 8 more: https://git.openjdk.java.net/jdk11u-dev/compare/74eed68892cf5c0fcde5d88eb0e1070e239b7af3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@TheRealMDoerr Pushed as commit 25cad2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants