Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210182: Remove macros for C compilation from vmTestBase but non jvmti #346

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 14, 2021

Backport of JDK-8210182: Remove macros for C compilation from vmTestBase but non jvmti. Changes apply clean, except for 3 files which don't exist in 11u:
test/hotspot/jtreg/vmTestbase/gc/g1/unloading/libdefine.cpp
test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/forceEarlyReturn/forceEarlyReturn005/libforceEarlyReturn005a.cpp
test/hotspot/jtreg/vmTestbase/nsk/share/locks/JNIMonitorLocker.cpp


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8210182: Remove macros for C compilation from vmTestBase but non jvmti

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/346/head:pull/346
$ git checkout pull/346

Update a local copy of the PR:
$ git checkout pull/346
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/346/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 346

View PR using the GUI difftool:
$ git pr show -t 346

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/346.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 14, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport d0560a286035c1495080f5bd60cf8e9bf671eeab 8210182: Remove macros for C compilation from vmTestBase but non jvmti Sep 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

This backport pull request has now been updated with issue and summary from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 14, 2021

Webrevs

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 14, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210182: Remove macros for C compilation from vmTestBase but non jvmti

Remove the macros and update the code

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 14, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 15, 2021

Backport doesn't work without JDK-8209611.

Loading

@RealCLanger RealCLanger deleted the RealCLanger-backport-d0560a28 branch Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants