-
Notifications
You must be signed in to change notification settings - Fork 251
8273795: Zero SPARC64 debug builds fail due to missing interpreter fields #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
coleenp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for cleaning this up.
|
@shipilev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks! I requested the 11u push approval. |
|
Got the push approval. /integrate |
|
Going to push as commit e3f923f.
Your commit was automatically rebased without conflicts. |
This is a SPARC-specific, Zero-specific, 11u-specific problem. See the bug trail investigation in the bug. @glaubitz, I don't suppose Debian builds OpenJDK 11u Zero SPARC64 fastdebug builds, so must have never faced this issue?
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/349/head:pull/349$ git checkout pull/349Update a local copy of the PR:
$ git checkout pull/349$ git pull https://git.openjdk.java.net/jdk11u-dev pull/349/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 349View PR using the GUI difftool:
$ git pr show -t 349Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/349.diff