Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273795: Zero SPARC64 debug builds fail due to missing interpreter fields #349

Closed
wants to merge 1 commit into from

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 15, 2021

This is a SPARC-specific, Zero-specific, 11u-specific problem. See the bug trail investigation in the bug. @glaubitz, I don't suppose Debian builds OpenJDK 11u Zero SPARC64 fastdebug builds, so must have never faced this issue?

Additional testing:

  • Linux SPARC64 Zero cross-compilation completes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273795: Zero SPARC64 debug builds fail due to missing interpreter fields

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/349/head:pull/349
$ git checkout pull/349

Update a local copy of the PR:
$ git checkout pull/349
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/349/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 349

View PR using the GUI difftool:
$ git pr show -t 349

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/349.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 15, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 15, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 15, 2021

Webrevs

Loading

Copy link
Contributor

@coleenp coleenp left a comment

Looks good. Thanks for cleaning this up.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 15, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273795: Zero SPARC64 debug builds fail due to missing interpreter fields

Reviewed-by: coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • 9437d45: 8252049: Native memory leak in ciMethodData ctor
  • 3319efb: 8268672: C2: assert(!loop->is_member(u_loop)) failed: can be in outer loop or out of both loops only
  • 87299f3: 8268019: C2: assert(no_dead_loop) failed: dead loop detected
  • 625690e: 8263303: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 15, 2021
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 16, 2021

Looks good. Thanks for cleaning this up.

Thanks! I requested the 11u push approval.

Loading

@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 16, 2021

Got the push approval.

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

Going to push as commit e3f923f.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 89a1f2a: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
  • 295f882: 8261036: Reduce classes loaded by CleanerFactory initialization
  • 25cad2f: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 0da130e: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 376d422: 8273358: macOS Monterey does not have the font Times needed by Serif
  • d79b68e: 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"
  • 2212683: 8213330: Fix legal headers in i18n tests
  • 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
  • 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/977ca313bfba0b51c3c06a5294e83b4ef9a45374...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@shipilev Pushed as commit e3f923f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@shipilev shipilev deleted the JDK-8273795-zero-sparc64 branch Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants