Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong #35

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jun 16, 2021

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/35/head:pull/35
$ git checkout pull/35

Update a local copy of the PR:
$ git checkout pull/35
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/35/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 35

View PR using the GUI difftool:
$ git pr show -t 35

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/35.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 16, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 49d04586ed27fc905083d60aa68793d84824c7f3 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong Jun 16, 2021
@openjdk
Copy link

openjdk bot commented Jun 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 16, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 57d8e1e: 8268127: Shenandoah: Heap size may be too small for region to align to large page size

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2021
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 16, 2021

Going to push as commit 9638c41.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 57d8e1e: 8268127: Shenandoah: Heap size may be too small for region to align to large page size

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 16, 2021
@openjdk
Copy link

openjdk bot commented Jun 16, 2021

@shipilev Pushed as commit 9638c41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jun 16, 2021

Webrevs

@shipilev shipilev deleted the JDK-8266288 branch June 16, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant