6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

[jmtd]

Backport of JDK-6849922 for jdk11u
Does not apply clean, RFR will be required (ProblemList.txt)
Pre-requisite for JDK-8214469

Test-only changes, awaiting tier1 test results regardless

Note: the test modified by this patch does not pass after applying it, at least on macos -- it does once JDK-8214469 is applied too (that comes next)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/351/head:pull/351
$ git checkout pull/351

Update a local copy of the PR:
$ git checkout pull/351
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/351/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 351

View PR using the GUI difftool:
$ git pr show -t 351

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/351.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (538ceafb)

[jmtd]

/test tier1

[jmtd]

Test ChoiceKeyEventReaction(.java) passes for me on x86_64 (without also backporting 8214469, which is required to pass on macos)

[RealCLanger]

Oh, you have beaten me by a few hours. I also started doing this backport (https://github.com/realclanger/jdk11u-dev/tree/RealCLanger-backport-1b012e21). 😆

Again, please rename this PR to "Backport <commit-hash>", e.g. 1b012e2 in this case, to make the bots correctly recognize it as a backport.

Furthermore, please enable Github Actions here: https://github.com/jmtd/jdk11u-dev/actions because this will give us more confidence.

And last but not least, I ran the test on Windows and it passes.

[jmtd]

Oh, you have beaten me by a few hours. I also started doing this backport (https://github.com/realclanger/jdk11u-dev/tree/RealCLanger-backport-1b012e21). 😆

Oh I'm sorry, I hate it when this happens to me! for 8u, we have/had a convention of labelling issues in JBS with jdk8u-<username> to signify "I am working on this". Is there any similar convention for 11u?

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 50 new commits pushed to the master branch:

• 89a1f2a: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
• 295f882: 8261036: Reduce classes loaded by CleanerFactory initialization
• 25cad2f: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
• 0da130e: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
• 376d422: 8273358: macOS Monterey does not have the font Times needed by Serif
• d79b68e: 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"
• 2212683: 8213330: Fix legal headers in i18n tests
• 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
• e9aaba4: 8169959: javax/swing/JTable/6263446/bug6263446.java: Table should be editing
• 579fbcb: 8271490: [ppc] [s390]: Crash in JavaThread::pd_get_top_frame_for_profiling
• ... and 40 more: https://git.openjdk.java.net/jdk11u-dev/compare/63fc945c1d4cdc893d89796804acfe0ce9341860...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[jmtd]

/integrate

[openjdk]

@jmtd
Your change (at version 538ceaf) is now ready to be sponsored by a Committer.

[RealCLanger]

Oh, you have beaten me by a few hours. I also started doing this backport (https://github.com/realclanger/jdk11u-dev/tree/RealCLanger-backport-1b012e21). 😆

Oh I'm sorry, I hate it when this happens to me! for 8u, we have/had a convention of labelling issues in JBS with jdk8u-<username> to signify "I am working on this". Is there any similar convention for 11u?

Well, it probably doesn't happen often. When I start, I obviously check whether a PR is already open. The moment you do this (correctly) it get's linked into the issue. The other way to claim a backport for myself would be to create a backport bug with the target release version. However, I usually would do this only for backports where I think the effort and time needed will be considerably high, not for simple apply & build & run tests type of patches.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit 48e5f41.
Since your change was applied there have been 57 commits pushed to the master branch:

• d754399: 8213110: Remove the use of applets in automatic tests
• 74c221b: 8269034: AccessControlException for SunPKCS11 daemon threads
• e34f047: 8240256: Better resource cleaning for SunPKCS11 Provider
• 3bddee5: 8210392: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit
• 54a9e3c: 8236177: assert(status == 0) failed: error ETIMEDOUT(60), cond_wait
• 777039b: 8246114: java/net/MulticastSocket/Promiscuous.java fails after 8241072 (multi-homed systems)
• e3f923f: 8273795: Zero SPARC64 debug builds fail due to missing interpreter fields
• 89a1f2a: 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2
• 295f882: 8261036: Reduce classes loaded by CleanerFactory initialization
• 25cad2f: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
• ... and 47 more: https://git.openjdk.java.net/jdk11u-dev/compare/63fc945c1d4cdc893d89796804acfe0ce9341860...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @jmtd Pushed as commit 48e5f41.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.