Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261036: Reduce classes loaded by CleanerFactory initialization #353

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 15, 2021

Clean backport of JDK-8261036.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261036: Reduce classes loaded by CleanerFactory initialization

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/353/head:pull/353
$ git checkout pull/353

Update a local copy of the PR:
$ git checkout pull/353
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/353/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 353

View PR using the GUI difftool:
$ git pr show -t 353

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/353.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 992b50087d2ec8878dfcbbd1820a00b6b6bdf644 8261036: Reduce classes loaded by CleanerFactory initialization Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261036: Reduce classes loaded by CleanerFactory initialization

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Sep 16, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2021

Going to push as commit 295f882.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 25cad2f: 8272806: [macOS] "Apple AWT Internal Exception" when input method is changed
  • 0da130e: 8269951: [macos] Focus not painted in JButton when setBorderPainted(false) is invoked
  • 376d422: 8273358: macOS Monterey does not have the font Times needed by Serif
  • d79b68e: 8218483: Crash in "assert(_daemon_threads_count->get_value() > daemon_count) failed: thread count mismatch 5 : 5"
  • 2212683: 8213330: Fix legal headers in i18n tests
  • 263d070: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@TheRealMDoerr Pushed as commit 295f882.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8261036_CleanerFactory branch Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant