Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2 #354

Closed
wants to merge 1 commit into from
Closed

8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2 #354

wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 15, 2021

Clean backport of JDK-8273541.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/354/head:pull/354
$ git checkout pull/354

Update a local copy of the PR:
$ git checkout pull/354
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/354/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 354

View PR using the GUI difftool:
$ git pr show -t 354

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/354.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/353 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4e6de5f9defc031158e027bcbbaf6232b8c03d60 8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2 Sep 15, 2021
@openjdk
Copy link

openjdk bot commented Sep 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Sep 15, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2021

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/353 to master September 16, 2021 12:42
@openjdk-notifier
Copy link

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8261036_CleanerFactory
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added clean and removed clean labels Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273541: Cleaner Thread creates with normal priority instead of MAX_PRIORITY - 2

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2021
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2021

Going to push as commit 89a1f2a.

@openjdk openjdk bot closed this Sep 16, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2021
@openjdk
Copy link

openjdk bot commented Sep 16, 2021

@TheRealMDoerr Pushed as commit 89a1f2a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8273541_CleanerFactory branch September 16, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant