Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8213110: Remove the use of applets in automatic tests #361

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 16, 2021

This is a backport of a test fix from 11.0.12 that was also downported by Oracle. Required some trivial resolves. Differences were mostly in the references to the test libraries and OSInfo. In detail:

ProblemList: The usual adaptions were necessary.

test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.html Pointless difference. Just deleted.
test/jdk/java/awt/Choice/PopupPosTest/PopupPosTest.java Trivial resolve.

test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.html Pointless difference. Just deleted.
test/jdk/java/awt/KeyboardFocusmanager/ConsumeNextMnemonicKeyTypedTest/ConsumeNextMnemonicKeyTypedTest.java Trivial resolve.

test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest.html Pointless difference. Just deleted.
test/jdk/java/awt/List/FirstItemRemoveTest/FirstItemRemoveTest Trivial resolve.

test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest.html Pointless difference. Just deleted.
test/jdk/java/awt/List/KeyEventsTest/KeyEventsTest Trivial resolve.

test/jdk/java/awt/datatransfer/MissedHtmlAndRtfBug/MissedHtmlAndRtfBug.html Pointless difference. Just deleted.
test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java Trivial resolve.

test/jdk/javax/swing/JFrame/4962534/bug4962534.java
test/jdk/javax/swing/JPopupMenu/4634626/bug4634626.java
Later fixes to method main() have been downported already. Resolved to the main() already in 11u-dev.

I ran all the tests, they succeed if you don't touch the mouse etc. test/jdk/java/awt/Focus/IconifiedFrameFocusChangeTest/IconifiedFrameFocusChangeTest.java is failing, but that one is ProblemListed and was failing before, too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8213110: Remove the use of applets in automatic tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/361/head:pull/361
$ git checkout pull/361

Update a local copy of the PR:
$ git checkout pull/361
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/361/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 361

View PR using the GUI difftool:
$ git pr show -t 361

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/361.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b5998aadf065404608e077b1064e56e99a537095 8213110: Remove the use of applets in automatic tests Sep 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Sep 16, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8213110: Remove the use of applets in automatic tests

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 777039b: 8246114: java/net/MulticastSocket/Promiscuous.java fails after 8241072 (multi-homed systems)
  • e3f923f: 8273795: Zero SPARC64 debug builds fail due to missing interpreter fields

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 16, 2021
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 17, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

Going to push as commit d754399.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 74c221b: 8269034: AccessControlException for SunPKCS11 daemon threads
  • e34f047: 8240256: Better resource cleaning for SunPKCS11 Provider
  • 3bddee5: 8210392: assert(Compile::current()->live_nodes() < Compile::current()->max_node_limit()) failed: Live Node limit exceeded limit
  • 54a9e3c: 8236177: assert(status == 0) failed: error ETIMEDOUT(60), cond_wait
  • 777039b: 8246114: java/net/MulticastSocket/Promiscuous.java fails after 8241072 (multi-homed systems)
  • e3f923f: 8273795: Zero SPARC64 debug builds fail due to missing interpreter fields

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 17, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 17, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@GoeLin Pushed as commit d754399.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_applets_downport branch Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants