Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8215410: Regression test for JDK-8214994 #364

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 17, 2021

Hi all,

this pull request contains a backport of JDK-8215410 from the openjdk/jdk repository.

The commit being backported was authored by Tobias Hartmann on 17 Dec 2018 and was reviewed by Vladimir Kozlov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/364/head:pull/364
$ git checkout pull/364

Update a local copy of the PR:
$ git checkout pull/364
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/364/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 364

View PR using the GUI difftool:
$ git pr show -t 364

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/364.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2e989366ea703f6eaa330f8a611ba01f27ef9997 8215410: Regression test for JDK-8214994 Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8215410: Regression test for JDK-8214994

Added a regression test for 8214994 which was fixed by accident with 8211451.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 17, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

RealCLanger commented Sep 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

Going to push as commit 7627023.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 8a2cb87: 8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently
  • 86cd9ba: 8213189: Make restricted headers in HTTP Client configurable and remove Date by default
  • 18e519c: 8256066: Tests use deprecated TestNG API that is no longer available in new versions
  • 0a40175: 8216318: The usage of Disposer in the java.awt.Robot can be deleted
  • ef06175: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails
  • b65b79b: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 9f51a40: 8270344: Session resumption errors
  • a925af4: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • 9d29c77: 8217633: Configurable extensions with system properties
  • 1bed6cd: 8253682: The AppletInitialFocusTest1.java is unstable
  • ... and 6 more: https://git.openjdk.java.net/jdk11u-dev/compare/777039b1e6a243d005d49d29e1d6d92aa6941daf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@RealCLanger Pushed as commit 7627023.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant