Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8216318: The usage of Disposer in the java.awt.Robot can be deleted #365

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 17, 2021

Clean backport of JDK-8216318.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8216318: The usage of Disposer in the java.awt.Robot can be deleted

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/365/head:pull/365
$ git checkout pull/365

Update a local copy of the PR:
$ git checkout pull/365
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 365

View PR using the GUI difftool:
$ git pr show -t 365

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/365.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 293f77f18f96fec80d9dd5cc082d045b5dd0b813 8216318: The usage of Disposer in the java.awt.Robot can be deleted Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Sep 17, 2021
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Sep 17, 2021

Not recognized as clean because of Copyright year changes.

@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

GoeLin
GoeLin approved these changes Sep 17, 2021
Copy link
Member

@GoeLin GoeLin left a comment

LGTM

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8216318: The usage of Disposer in the java.awt.Robot can be deleted

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • d754399: 8213110: Remove the use of applets in automatic tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 17, 2021
@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Sep 20, 2021

Thanks for the review!
/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@TheRealMDoerr Unable to acquire the integration lock; aborting integration. The error has been logged and will be investigated.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Sep 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

Going to push as commit 0a40175.
Since your change was applied there have been 8 commits pushed to the master branch:

  • ef06175: 8197560: test javax/swing/JTree/8003400/Test8003400.java fails
  • b65b79b: 8271560: sun/security/ssl/DHKeyExchange/LegacyDHEKeyExchange.java still fails due to "An established connection was aborted by the software in your host machine"
  • 9f51a40: 8270344: Session resumption errors
  • a925af4: 8259237: Demo selection changes with left/right arrow key. No need to press space for selection.
  • 9d29c77: 8217633: Configurable extensions with system properties
  • 1bed6cd: 8253682: The AppletInitialFocusTest1.java is unstable
  • 48e5f41: 6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
  • d754399: 8213110: Remove the use of applets in automatic tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@TheRealMDoerr Pushed as commit 0a40175.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8216318_awt branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants