Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259237: Demo selection changes with left/right arrow key. No need to press space for selection. #366

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 17, 2021

Clean backport of JDK-8259237.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8259237: Demo selection changes with left/right arrow key. No need to press space for selection.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/366/head:pull/366
$ git checkout pull/366

Update a local copy of the PR:
$ git checkout pull/366
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/366/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 366

View PR using the GUI difftool:
$ git pr show -t 366

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/366.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 28ff2de1860bf70b1174fd434346be750d9dbf01 8259237: Demo selection changes with left/right arrow key. No need to press space for selection. Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259237: Demo selection changes with left/right arrow key. No need to press space for selection.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 17, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Sep 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

Going to push as commit a925af4.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 9d29c77: 8217633: Configurable extensions with system properties
  • 1bed6cd: 8253682: The AppletInitialFocusTest1.java is unstable
  • 48e5f41: 6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails
  • d754399: 8213110: Remove the use of applets in automatic tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@TheRealMDoerr Pushed as commit a925af4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8259237_swing branch Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant