Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273939: Backport of 8248414 to JDK11 breaks MacroAssembler::adrp #369

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Sep 17, 2021

This is not a backport. This fixes issue in backport of 8248414.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273939: Backport of 8248414 to JDK11 breaks MacroAssembler::adrp

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/369/head:pull/369
$ git checkout pull/369

Update a local copy of the PR:
$ git checkout pull/369
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/369/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 369

View PR using the GUI difftool:
$ git pr show -t 369

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/369.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Sep 17, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 17, 2021

Webrevs

Loading

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM. Seems like removal was done by mistake in bf01efa

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 17, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273939: Backport of 8248414 to JDK11 breaks MacroAssembler::adrp

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 17, 2021
@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Sep 17, 2021

Note: If you get it approved as 'jdk11u-critical-yes' you may need a PR for jdk11u and to close this one.

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Sep 17, 2021

Thanks for the note, created openjdk/jdk11u#11 , will close one of these PRs, depending on type of approval I will get

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Sep 18, 2021

Closing this one , will integrate the one into jdk11u

Loading

@VladimirKempik VladimirKempik deleted the JDK-8273939 branch Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants