Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253682: The is unstable #372

wants to merge 1 commit into from


Copy link

@GoeLin GoeLin commented Sep 17, 2021


I would like to downport this test fix for parity with oracle jdk 11.0.12.

I applies clean after pushing "8213110: Remove the use of applets in automatic tests"

Only a test fix, thus no risk for the VM.


  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue


  • JDK-8253682: The is unstable


Using git

Checkout this PR locally:
$ git fetch pull/372/head:pull/372
$ git checkout pull/372

Update a local copy of the PR:
$ git checkout pull/372
$ git pull pull/372/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 372

View PR using the GUI difftool:
$ git pr show -t 372

Using diff file

Download this PR as a diff file:

Copy link

@bridgekeeper bridgekeeper bot commented Sep 17, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1d88172c0688da48753c009355db244f249c9ebe 8253682: The is unstable Sep 17, 2021
Copy link

@openjdk openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue from the original commit.

Copy link

@openjdk openjdk bot commented Sep 17, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253682: The is unstable

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Copy link

@mlbridge mlbridge bot commented Sep 17, 2021


Copy link
Member Author

@GoeLin GoeLin commented Sep 20, 2021


Copy link

@openjdk openjdk bot commented Sep 20, 2021

Going to push as commit 1bed6cd.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 48e5f41: 6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 20, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 20, 2021
Copy link

@openjdk openjdk bot commented Sep 20, 2021

@GoeLin Pushed as commit 1bed6cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant