Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 17, 2021

Downport for 11.0.13 parity.

I only had to resolve the ProblemList, the fix applied clean to the test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/375/head:pull/375
$ git checkout pull/375

Update a local copy of the PR:
$ git checkout pull/375
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 375

View PR using the GUI difftool:
$ git pr show -t 375

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/375.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1b012e213d31b184236a56121f7f1548d1a6fe05 6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

6849922: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.html fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 17, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

@GoeLin GoeLin closed this Sep 20, 2021
@GoeLin GoeLin deleted the backport_6849922 branch September 21, 2021 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant