8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

[jmtd]

JBS: https://bugs.openjdk.java.net/browse/JDK-8272342

Please consider approving this for 11u. It's a test-only change. The test always passes prior to applying the patch, even if you deliberately supply invalid values. It also localizes the UI so, in my case, the test asks me to set a margin to 2 inches, but my localized UI lists the units in mm.

Patch applies clean. After applying, the UI is localized to US (so shows inches), passes if you follow the instructions, and fails if you do not, as it should.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/377/head:pull/377
$ git checkout pull/377

Update a local copy of the PR:
$ git checkout pull/377
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/377/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 377

View PR using the GUI difftool:
$ git pr show -t 377

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/377.diff

[bridgekeeper]

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 71 new commits pushed to the master branch:

• 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
• e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
• f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
• 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
• 245ccb2: 8269768: JFR Terminology Refresh
• 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
• 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
• b4b50cb: Merge
• c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
• ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name
• ... and 61 more: https://git.openjdk.java.net/jdk11u-dev/compare/48e5f412b6cd09e9d79332a033ac04c9260b1c7c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (3f47f32f)

[jmtd]

/test tier1

[RealCLanger]

This one is also due for integration.

[jmtd]

/integrate

[openjdk]

@jmtd
Your change (at version 3f47f32) is now ready to be sponsored by a Committer.

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit dce04a2.
Since your change was applied there have been 71 commits pushed to the master branch:

• 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
• e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
• f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
• 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
• 245ccb2: 8269768: JFR Terminology Refresh
• 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
• 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
• b4b50cb: Merge
• c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
• ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name
• ... and 61 more: https://git.openjdk.java.net/jdk11u-dev/compare/48e5f412b6cd09e9d79332a033ac04c9260b1c7c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @jmtd Pushed as commit dce04a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.