Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 20, 2021

I downport this for parity with 11.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8217882: java/net/httpclient/MaxStreams.java failed once

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/380/head:pull/380
$ git checkout pull/380

Update a local copy of the PR:
$ git checkout pull/380
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/380/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 380

View PR using the GUI difftool:
$ git pr show -t 380

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/380.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6dcfd0f93a05df49ae27be28ce9529ae5cbe2c7a 8217882: java/net/httpclient/MaxStreams.java failed once Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8217882: java/net/httpclient/MaxStreams.java failed once

Added some more traces to help diagnosis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 21, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2021

Going to push as commit 005b8b9.
Since your change was applied there have been 10 commits pushed to the master branch:

  • a13296f: 8217903: java/net/httpclient/Response204.java fails with 404
  • 231fdea: 8217377: javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception
  • 9accd6b: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events
  • 0d49433: 8272850: Drop zapping values in the Zap* option descriptions
  • 78e18d4: 8272318: Improve performance of HeapDumpAllTest
  • 7627023: 8215410: Regression test for JDK-8214994
  • 8a2cb87: 8129310: java/net/Socket/asyncClose/AsyncClose.java fails intermittently
  • 86cd9ba: 8213189: Make restricted headers in HTTP Client configurable and remove Date by default
  • 18e519c: 8256066: Tests use deprecated TestNG API that is no longer available in new versions
  • 0a40175: 8216318: The usage of Disposer in the java.awt.Robot can be deleted

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2021
@openjdk
Copy link

openjdk bot commented Sep 21, 2021

@GoeLin Pushed as commit 005b8b9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant