Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8221259: New tests for java.net.Socket to exercise long standing behavior #384

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 20, 2021

Hi all,

this pull request contains a backport of JDK-8221259 from the openjdk/jdk repository.
The commit being backported was authored by Alan Bateman on 21 Mar 2019 and was reviewed by Chris Hegarty.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8221259: New tests for java.net.Socket to exercise long standing behavior

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/384/head:pull/384
$ git checkout pull/384

Update a local copy of the PR:
$ git checkout pull/384
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/384/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 384

View PR using the GUI difftool:
$ git pr show -t 384

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/384.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport fd14375ae262f68cb9f76b0e45d1627438e37c75 8221259: New tests for java.net.Socket to exercise long standing behavior Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 20, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8221259: New tests for java.net.Socket to exercise long standing behavior

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

Failling GHA test gc/metaspace/TestMetaspacePerfCounters.java in linux x86 seems to be somwhat intermittent. Not related to this patch.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

Going to push as commit 8fc3d89.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 16ef602: 8217438: Adapt tools//launcher/Test7029048.java for AIX
  • ae849c1: 8080569: java/lang/ProcessBuilder/DestroyTest.java fails with "RuntimeException: Process terminated prematurely"
  • 62207ef: 8261297: NMT: Final report should use scale 1
  • 005b8b9: 8217882: java/net/httpclient/MaxStreams.java failed once
  • a13296f: 8217903: java/net/httpclient/Response204.java fails with 404
  • 231fdea: 8217377: javax/swing/JPopupMenu/6583251/bug6583251.java failed with UnsupportedOperation exception
  • 9accd6b: 8269574: C2: Avoid redundant uncommon traps in GraphKit::builtin_throw() for JVMTI exception events
  • 0d49433: 8272850: Drop zapping values in the Zap* option descriptions
  • 78e18d4: 8272318: Improve performance of HeapDumpAllTest

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@RealCLanger Pushed as commit 8fc3d89.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant