Skip to content

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 20, 2021

Backport of JDK-8210920: Native C++ tests are not using CXXFLAGS


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/385/head:pull/385
$ git checkout pull/385

Update a local copy of the PR:
$ git checkout pull/385
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/385/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 385

View PR using the GUI difftool:
$ git pr show -t 385

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/385.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 481a045635fd3cafadf2e5314570b1bf6e45ba89 8210920: Native C++ tests are not using CXXFLAGS Sep 20, 2021
@openjdk
Copy link

openjdk bot commented Sep 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Sep 20, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210920: Native C++ tests are not using CXXFLAGS

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 0405d46: 8233634: [TESTBUG] Swing text test bug4278839.java fails on macos
  • 133de42: 8228508: [TESTBUG] java/net/httpclient/SmokeTest.java fails on Windows7
  • d78b4c7: 8233403: Improve verbosity of some httpclient tests
  • 8c2cecc: 8165828: [TEST_BUG] The reg case:javax/swing/plaf/metal/MetalIcons/MetalHiDPIIconsTest.java failed as No Metal Look and Feel
  • 52c1288: Merge
  • f336c72: 8273939: Backport of 8248414 to JDK11 breaks MacroAssembler::adrp
  • 8fc3d89: 8221259: New tests for java.net.Socket to exercise long standing behavior
  • 16ef602: 8217438: Adapt tools//launcher/Test7029048.java for AIX
  • ae849c1: 8080569: java/lang/ProcessBuilder/DestroyTest.java fails with "RuntimeException: Process terminated prematurely"
  • 62207ef: 8261297: NMT: Final report should use scale 1
  • ... and 6 more: https://git.openjdk.java.net/jdk11u-dev/compare/7627023d4cd649024af651cae956c7a9a0b21bc6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 22, 2021
@RealCLanger
Copy link
Contributor Author

Thanks for the review.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2021

Going to push as commit 426906b.
Since your change was applied there have been 24 commits pushed to the master branch:

  • cbe5a58: 8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu
  • 4f3e010: 8242526: PIT: javax/swing/JInternalFrame/8020708/bug8020708.java fails in mach5 ubuntu system
  • 7e73841: 8234802: [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms
  • 92e1f21: 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server
  • ae60ed6: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 43861d7: 8215568: Refactor SA clhsdb tests to use ClhsdbLauncher
  • b9307bd: 8214469: [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails
  • 86cf496: 8222446: assert(C->env()->system_dictionary_modification_counter_changed()) failed: Must invalidate if TypeFuncs differ
  • 0405d46: 8233634: [TESTBUG] Swing text test bug4278839.java fails on macos
  • 133de42: 8228508: [TESTBUG] java/net/httpclient/SmokeTest.java fails on Windows7
  • ... and 14 more: https://git.openjdk.java.net/jdk11u-dev/compare/7627023d4cd649024af651cae956c7a9a0b21bc6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2021
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@RealCLanger Pushed as commit 426906b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-481a0456 branch September 24, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants