New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8180569: Refactor sun/security/krb5/ shell tests to plain java tests #386
8180569: Refactor sun/security/krb5/ shell tests to plain java tests #386
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
No idea why GHA was failing in compiler/jsr292/PollutedTrapCounts.java and how it could be related to this backport. Merging once again with master to retrigger actions. |
39e56cd
to
3b5b979
Compare
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
I made a mistake in resolving. It's now corrected and backport was marked clean by the bots. Let's see if GHA run through now but local testing lets me believe it will :) |
/integrate |
Going to push as commit 7b1cf54.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 7b1cf54. |
Backport of JDK-8180569 Refactor sun/security/krb5/ shell tests to plain java tests
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/386/head:pull/386
$ git checkout pull/386
Update a local copy of the PR:
$ git checkout pull/386
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/386/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 386
View PR using the GUI difftool:
$ git pr show -t 386
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/386.diff