Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8180569: Refactor sun/security/krb5/ shell tests to plain java tests #386

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 20, 2021

Backport of JDK-8180569 Refactor sun/security/krb5/ shell tests to plain java tests


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8180569: Refactor sun/security/krb5/ shell tests to plain java tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/386/head:pull/386
$ git checkout pull/386

Update a local copy of the PR:
$ git checkout pull/386
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/386/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 386

View PR using the GUI difftool:
$ git pr show -t 386

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/386.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 20, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8b83b515b1981557ab27703482b4c14ca4cdb11c 8180569: Refactor sun/security/krb5/ shell tests to plain java tests Sep 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Sep 20, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 20, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 21, 2021

No idea why GHA was failing in compiler/jsr292/PollutedTrapCounts.java and how it could be related to this backport. Merging once again with master to retrigger actions.

@RealCLanger RealCLanger force-pushed the RealCLanger-backport-8b83b515 branch from 39e56cd to 3b5b979 Compare Sep 22, 2021
@openjdk openjdk bot added the clean label Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8180569: Refactor sun/security/krb5/ shell tests to plain java tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 22, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 22, 2021

No idea why GHA was failing in compiler/jsr292/PollutedTrapCounts.java and how it could be related to this backport. Merging once again with master to retrigger actions.

I made a mistake in resolving. It's now corrected and backport was marked clean by the bots. Let's see if GHA run through now but local testing lets me believe it will :)

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 24, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

Going to push as commit 7b1cf54.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 426906b: 8210920: Native C++ tests are not using CXXFLAGS
  • cbe5a58: 8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu
  • 4f3e010: 8242526: PIT: javax/swing/JInternalFrame/8020708/bug8020708.java fails in mach5 ubuntu system
  • 7e73841: 8234802: [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms
  • 92e1f21: 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server
  • ae60ed6: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 43861d7: 8215568: Refactor SA clhsdb tests to use ClhsdbLauncher
  • b9307bd: 8214469: [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails
  • 86cf496: 8222446: assert(C->env()->system_dictionary_modification_counter_changed()) failed: Must invalidate if TypeFuncs differ
  • 0405d46: 8233634: [TESTBUG] Swing text test bug4278839.java fails on macos
  • ... and 8 more: https://git.openjdk.java.net/jdk11u-dev/compare/62207ef2b9fd930edf4e22fcb82331968453a1d7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@RealCLanger Pushed as commit 7b1cf54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-8b83b515 branch Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant