Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233403: Improve verbosity of some httpclient tests #390

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 21, 2021

I downport this for parity with 11.0.13-oracle.

It applied clean except for the changes to the includes in four of the files. Only context differences.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233403: Improve verbosity of some httpclient tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/390/head:pull/390
$ git checkout pull/390

Update a local copy of the PR:
$ git checkout pull/390
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/390/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 390

View PR using the GUI difftool:
$ git pr show -t 390

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/390.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 21, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eaba9fe23b097338e5d567adec70873a8d4aed8f 8233403: Improve verbosity of some httpclient tests Sep 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 21, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233403: Improve verbosity of some httpclient tests

Improve the verbosity of some httpclient tests to help diagnosis of intermittent failures. Also fixes ShortRequestBody test.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 21, 2021

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 22, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

Going to push as commit d78b4c7.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 8c2cecc: 8165828: [TEST_BUG] The reg case:javax/swing/plaf/metal/MetalIcons/MetalHiDPIIconsTest.java failed as No Metal Look and Feel
  • 52c1288: Merge
  • f336c72: 8273939: Backport of 8248414 to JDK11 breaks MacroAssembler::adrp
  • 8fc3d89: 8221259: New tests for java.net.Socket to exercise long standing behavior
  • 16ef602: 8217438: Adapt tools//launcher/Test7029048.java for AIX
  • ae849c1: 8080569: java/lang/ProcessBuilder/DestroyTest.java fails with "RuntimeException: Process terminated prematurely"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@GoeLin Pushed as commit d78b4c7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the backport_8233403 branch Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant