Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version #395

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 22, 2021

I downport this for parity with 11.0.13-oracle.
Applies clean except for deleting the keystore files.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/395/head:pull/395
$ git checkout pull/395

Update a local copy of the PR:
$ git checkout pull/395
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 395

View PR using the GUI difftool:
$ git pr show -t 395

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/395.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 22, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport fbca3fa710d8068e39eee574813c35f1d60fabe5 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version Sep 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 22, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 22, 2021

Webrevs

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 24, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

Going to push as commit 3d21c7c.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 7b1cf54: 8180569: Refactor sun/security/krb5/ shell tests to plain java tests
  • 426906b: 8210920: Native C++ tests are not using CXXFLAGS
  • cbe5a58: 8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu
  • 4f3e010: 8242526: PIT: javax/swing/JInternalFrame/8020708/bug8020708.java fails in mach5 ubuntu system
  • 7e73841: 8234802: [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms
  • 92e1f21: 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server
  • ae60ed6: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 43861d7: 8215568: Refactor SA clhsdb tests to use ClhsdbLauncher
  • b9307bd: 8214469: [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails
  • 86cf496: 8222446: assert(C->env()->system_dictionary_modification_counter_changed()) failed: Must invalidate if TypeFuncs differ

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

@GoeLin Pushed as commit 3d21c7c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@GoeLin GoeLin deleted the backport_8238677 branch Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant