Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 22, 2021

I downport this for parity with 11.0.13-oracle.

Applied clean except for context in ProblemList.txt.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/399/head:pull/399
$ git checkout pull/399

Update a local copy of the PR:
$ git checkout pull/399
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 399

View PR using the GUI difftool:
$ git pr show -t 399

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/399.diff

@GoeLin
Copy link
Member Author

GoeLin commented Sep 22, 2021

/clean

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4071546506d33b2bf74dc811b28dd8653f315be6 8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8221902: PIT: javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java fails on ubuntu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2021
@openjdk
Copy link

openjdk bot commented Sep 22, 2021

@GoeLin @GoeLin this backport pull request is already marked as clean

@mlbridge
Copy link

mlbridge bot commented Sep 22, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 23, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2021

Going to push as commit cbe5a58.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 4f3e010: 8242526: PIT: javax/swing/JInternalFrame/8020708/bug8020708.java fails in mach5 ubuntu system
  • 7e73841: 8234802: [TESTBUG] Test Right Mouse Button Drag Gesture Recognition in all the platforms
  • 92e1f21: 8242044: Add basic HTTP/1.1 support to the HTTP/2 Test Server
  • ae60ed6: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04
  • 43861d7: 8215568: Refactor SA clhsdb tests to use ClhsdbLauncher
  • b9307bd: 8214469: [macos] PIT: java/awt/Choice/ChoiceKeyEventReaction/ChoiceKeyEventReaction.java fails
  • 86cf496: 8222446: assert(C->env()->system_dictionary_modification_counter_changed()) failed: Must invalidate if TypeFuncs differ

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 23, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2021
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

@GoeLin Pushed as commit cbe5a58.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the backport_8221902 branch September 23, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant