Skip to content

8230019: [REDO] compiler/types/correctness/* tests fail with "assert(recv == __null || recv->is_klass()) failed: wrong type" #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 23, 2021

I downport this for parity with 11.0.13-oracle.

I had to resolve the ProblemList.
I took the version of the new patch.
The old bug mentioned, JDK-8066173, was closed with a patch just modifying the ProblemList -- which is strange.
The new bug, JDK-8225620, was closed, too. But it was not resolved, it was only closed because the solaris port was removed.
So I think mentioning the new bug is the right thing here.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8230019: [REDO] compiler/types/correctness/* tests fail with "assert(recv == __null || recv->is_klass()) failed: wrong type"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/402/head:pull/402
$ git checkout pull/402

Update a local copy of the PR:
$ git checkout pull/402
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/402/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 402

View PR using the GUI difftool:
$ git pr show -t 402

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/402.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6df28153fd7c5371a6b92f62addf03465ecf4eee 8230019: [REDO] compiler/types/correctness/* tests fail with "assert(recv == __null || recv->is_klass()) failed: wrong type" Sep 23, 2021
@openjdk
Copy link

openjdk bot commented Sep 23, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 23, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 23, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have never observed this issue in 11, but I think it's better to have the new version and enable the tests. Backport LGTM.

@openjdk
Copy link

openjdk bot commented Sep 27, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230019: [REDO] compiler/types/correctness/* tests fail with "assert(recv == __null || recv->is_klass()) failed: wrong type"

Explicitly set the receiver klass in the ci MDO to NULL if it is NULL in the MDO while translating.

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 98f17df: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
  • 79118a1: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
  • 6414dec: 8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
  • 8e7259e: 8255722: Create a new test for rotated blit
  • 1eb1ce8: 8245665: Test WeakAlg.java should only make sure no warning for weak signature algorithms by keytool on root CA
  • f0e7779: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 8bf4dd7: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList
  • 85b7756: 8263773: Reenable German localization for builds at Oracle
  • 3d21c7c: 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version
  • 7b1cf54: 8180569: Refactor sun/security/krb5/ shell tests to plain java tests
  • ... and 1 more: https://git.openjdk.java.net/jdk11u-dev/compare/cbe5a58e3ac3941d6bda33b6353c1ced41a12ae7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 27, 2021
@GoeLin
Copy link
Member Author

GoeLin commented Sep 28, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

Going to push as commit d234b6d.
Since your change was applied there have been 13 commits pushed to the master branch:

  • d7ac85a: 8244292: Headful clients failing with --illegal-access=deny
  • 45906dc: 8223658: Performance regression of XML.validation in 13-b19
  • 98f17df: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
  • 79118a1: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
  • 6414dec: 8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
  • 8e7259e: 8255722: Create a new test for rotated blit
  • 1eb1ce8: 8245665: Test WeakAlg.java should only make sure no warning for weak signature algorithms by keytool on root CA
  • f0e7779: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 8bf4dd7: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList
  • 85b7756: 8263773: Reenable German localization for builds at Oracle
  • ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/cbe5a58e3ac3941d6bda33b6353c1ced41a12ae7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@GoeLin Pushed as commit d234b6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8230019 branch September 28, 2021 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants