Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223658: Performance regression of XML.validation in 13-b19 #405

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 24, 2021

Hi all,

this pull request contains a backport of JDK-8223658 from the openjdk/jdk repository.

The commit being backported was authored by Joe Wang on 24 May 2019 and was reviewed by Lance Andersen.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223658: Performance regression of XML.validation in 13-b19

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/405/head:pull/405
$ git checkout pull/405

Update a local copy of the PR:
$ git checkout pull/405
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 405

View PR using the GUI difftool:
$ git pr show -t 405

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/405.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 24, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 50eb86d003e88109beb70726f897ad18e96a2a81 8223658: Performance regression of XML.validation in 13-b19 Sep 24, 2021
@openjdk
Copy link

openjdk bot commented Sep 24, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 24, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223658: Performance regression of XML.validation in 13-b19

Reviewed-by: sviswanathan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 98f17df: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
  • 79118a1: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
  • 6414dec: 8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
  • 8e7259e: 8255722: Create a new test for rotated blit
  • 1eb1ce8: 8245665: Test WeakAlg.java should only make sure no warning for weak signature algorithms by keytool on root CA
  • f0e7779: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 8bf4dd7: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList
  • 85b7756: 8263773: Reenable German localization for builds at Oracle
  • 3d21c7c: 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version
  • 7b1cf54: 8180569: Refactor sun/security/krb5/ shell tests to plain java tests

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 24, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 24, 2021

Webrevs

Copy link

@sviswa7 sviswa7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

Going to push as commit 45906dc.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 98f17df: 8039261: [TEST_BUG]: There is not a minimal security level in Java Preferences and the TestApplet.html is blocked.
  • 79118a1: 8264824: java/net/Inet6Address/B6206527.java doesn't close ServerSocket properly
  • 6414dec: 8250839: Improve test template SSLEngineTemplate with SSLContextTemplate
  • 8e7259e: 8255722: Create a new test for rotated blit
  • 1eb1ce8: 8245665: Test WeakAlg.java should only make sure no warning for weak signature algorithms by keytool on root CA
  • f0e7779: 8169954: JFileChooser/8021253: java.lang.RuntimeException: Default button is not pressed
  • 8bf4dd7: 8245165: Update bug id for javax/swing/text/StyledEditorKit/4506788/bug4506788.java in ProblemList
  • 85b7756: 8263773: Reenable German localization for builds at Oracle
  • 3d21c7c: 8238677: java/net/httpclient/ssltest/CertificateTest.java should not specify TLS version
  • 7b1cf54: 8180569: Refactor sun/security/krb5/ shell tests to plain java tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@RealCLanger Pushed as commit 45906dc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants