Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8180573: Refactor sun/security/tools shell tests to plain java tests #415

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 24, 2021

Backport of JDK-8180573: Refactor sun/security/tools shell tests to plain java tests

Applies mostly clean, deletion of a few files had to be done manually. Then I had to resolve the testlibrary in two places and add a a few tweaks to a few tests that came later with some CPU fixes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8180573: Refactor sun/security/tools shell tests to plain java tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/415/head:pull/415
$ git checkout pull/415

Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 415

View PR using the GUI difftool:
$ git pr show -t 415

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/415.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 24, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 15aae2f622fc0b1104d8adbcbd87792168538463 8180573: Refactor sun/security/tools shell tests to plain java tests Sep 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 24, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 24, 2021

Loading

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8180573: Refactor sun/security/tools shell tests to plain java tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Sep 27, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 1, 2021

@GoeLin @TheRealMDoerr This one is passing SAP regression tests now...

Loading

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Thumbs up!

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 5, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

Going to push as commit efef574.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 2b9261a: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral
  • a2bd0a9: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • 6f51eb4: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero
  • d86cf10: 8223138: Small clean-up in loop-tree support.
  • 3b88f74: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar
  • 6285123: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • 89ee611: 8223923: C2: Missing interference with mismatched unsafe accesses
  • f12af7e: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 28dec4f: 8223139: Rename mandatory policy-do routines.
  • e1cbfa5: 8248187: [TESTBUG] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/2990ff065935cc2a2b487fb88335e58b7edaa6cf...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@RealCLanger Pushed as commit efef574.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@RealCLanger RealCLanger deleted the RealCLanger-backport-15aae2f6 branch Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants