New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8180573: Refactor sun/security/tools shell tests to plain java tests #415
8180573: Refactor sun/security/tools shell tests to plain java tests #415
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@RealCLanger This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the
|
@GoeLin @TheRealMDoerr This one is passing SAP regression tests now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up!
/integrate |
Going to push as commit efef574.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit efef574. |
Backport of JDK-8180573: Refactor sun/security/tools shell tests to plain java tests
Applies mostly clean, deletion of a few files had to be done manually. Then I had to resolve the testlibrary in two places and add a a few tweaks to a few tests that came later with some CPU fixes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/415/head:pull/415
$ git checkout pull/415
Update a local copy of the PR:
$ git checkout pull/415
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/415/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 415
View PR using the GUI difftool:
$ git pr show -t 415
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/415.diff