Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos #426

Closed
wants to merge 1 commit into from

Conversation

@jmtd
Copy link

@jmtd jmtd commented Sep 27, 2021

This is a nearly-trivial backport of a test-only bug fix for 11u. Oracle backported this in 11.0.13-oracle . It applies clean except for ProblemList.txt.

Prior to backport, the test in 11u passes for me on macos anyway. Reading a comment by Philip Race [1], the underlying bug was believed to have been fixed by 225144 which is already backported. However they continued to see some test failures after 225144, which were presumably eventually addressed by this patch which followed it.

Please consider either for 11u or I request the bug be labelled jdk11u-na.

Thanks!

[1] https://bugs.openjdk.java.net/browse/JDK-8233569?focusedCommentId=14339145


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/426/head:pull/426
$ git checkout pull/426

Update a local copy of the PR:
$ git checkout pull/426
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/426/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 426

View PR using the GUI difftool:
$ git pr show -t 426

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/426.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 27, 2021

👋 Welcome back jdowland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 518ff518e1f90bf195c56b5f935bffa07059ee6b 8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos Sep 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 27, 2021

@jmtd This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • 23c3845: 8229935: [TEST_BUG]: bug8132119.java inconsistently positions text
  • ed98060: 8223137: Rename predicate 'do_unroll_only()' to 'is_unroll_only()'.
  • b79e707: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • b9f0143: 8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails
  • 05cb444: 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures
  • dce04a2: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
  • e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
  • f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
  • 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • ... and 27 more: https://git.openjdk.java.net/jdk11u-dev/compare/8bf4dd71874135e4b44ef9678cbdd65e3edf311f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 27, 2021

Webrevs

@jmtd
Copy link
Author

@jmtd jmtd commented Oct 1, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@jmtd
Your change (at version 238ff49) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 1, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

Going to push as commit 9f8c13c.
Since your change was applied there have been 38 commits pushed to the master branch:

  • a6ee356: 8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10
  • 23c3845: 8229935: [TEST_BUG]: bug8132119.java inconsistently positions text
  • ed98060: 8223137: Rename predicate 'do_unroll_only()' to 'is_unroll_only()'.
  • b79e707: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • b9f0143: 8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails
  • 05cb444: 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures
  • dce04a2: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
  • e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
  • f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
  • ... and 28 more: https://git.openjdk.java.net/jdk11u-dev/compare/8bf4dd71874135e4b44ef9678cbdd65e3edf311f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@RealCLanger @jmtd Pushed as commit 9f8c13c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants